lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6695e45f-4530-ab39-923d-8347649762bb@embeddedor.com>
Date:   Wed, 22 Sep 2021 18:12:37 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Tommaso Merciai <tomm.merciai@...il.com>
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Lucas Henneman <lucas.henneman@...aro.org>,
        Madhumitha Prabakaran <madhumithabiw@...il.com>,
        Yujia Qiao <rapiz@...mail.com>,
        Marcos Antonio de Jesus Filho <mdejesusfilho@...il.com>,
        Edmundo Carmona Antoranz <eantoranz@...il.com>,
        Aldas Taraškevičius <aldas60@...il.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Deepak R Varma <mh12gx2825@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: Replace camel case variable name



On 9/22/21 17:51, Tommaso Merciai wrote:
> Work in progress: replace camel case variables
> 
> PortOffset -> port_offset
> 
> Signed-off-by: Tommaso Merciai <tomm.merciai@...il.com>
> ---

When someone gives you feedback and you have to respin your
patch, you should version the patches that you resend, and
mention what changed, here:

Changes in v2:
 - Variable should be port_offset instead of port_off_set.

I encourage you to take a look at this:

https://kernelnewbies.org/Outreachyfirstpatch

It will be of great help if you are trying to land
your first patches. :)

--
Gustavo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ