linux-kernel - Re: [PATCH V2] arm64/mm: Add pud_sect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <127b2334-5c40-1b71-e510-ac837c3ac614@arm.com>
Date:   Wed, 22 Sep 2021 10:14:42 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, mark.rutland@....com,
        suzuki.poulose@....com, Will Deacon <will@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] arm64/mm: Add pud_sect_supported()



On 9/20/21 9:11 PM, Catalin Marinas wrote:
> On Mon, Sep 20, 2021 at 02:59:31PM +0530, Anshuman Khandual wrote:
>> Section mapping at PUD level is supported only on 4K pages and currently it
>> gets verified with explicit #ifdef or IS_ENABLED() constructs. This adds a
>> new helper pud_sect_supported() for this purpose, which particularly cleans
>> up the HugeTLB code path. It updates relevant switch statements with checks
>> for __PAGETABLE_PMD_FOLDED in order to avoid build failures caused with two
>> identical switch case values in those code blocks.
>>
>> Cc: Catalin Marinas <catalin.marinas@....com>
>> Cc: Will Deacon <will@...nel.org>
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Cc: linux-kernel@...r.kernel.org
>> Suggested-by: Mark Rutland <mark.rutland@....com>
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
> 
> Assuming that you tested the corresponding configurations,

Right, I did test this on all page size and VA bits configurations
, including the specific ones which were problematic.

> 
> Reviewed-by: Catalin Marinas <catalin.marinas@....com>
>