linux-kernel - Re: [PATCH v2] scsi: libiscsi: move init ehwait to iscsi_session

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163228527477.25516.7622823180692115909.b4-ty@oracle.com>
Date:   Wed, 22 Sep 2021 00:45:16 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     michael.christie@...cle.com, lduncan@...e.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ding Hui <dinghui@...gfor.com.cn>, jejb@...ux.ibm.com,
        open-iscsi@...glegroups.com, cleech@...hat.com
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v2] scsi: libiscsi: move init ehwait to iscsi_session_setup()

On Sat, 11 Sep 2021 21:51:59 +0800, Ding Hui wrote:

> The commit ec29d0ac29be ("scsi: iscsi: Fix conn use after free during
> resets") move member ehwait from conn to session, but left init ehwait
> in iscsi_conn_setup().
> 
> Although a session can only have 1 conn currently, it is better to
> do init ehwait in iscsi_session_setup() to prevent reinit by mistake,
> also in case we can handle multiple conns in the future.
> 
> [...]

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: libiscsi: move init ehwait to iscsi_session_setup()
      https://git.kernel.org/mkp/scsi/c/e018f03d6ccb

-- 
Martin K. Petersen	Oracle Linux Engineering