linux-kernel - Re: [PATCH V2] arm64/mm: Add pud_sect_supported()

Open Source and information security mailing list archives

Message-ID: <da59cd2e-9666-b236-8b23-49bd51a1c784@arm.com>
Date:   Wed, 22 Sep 2021 10:37:27 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     Itaru Kitayama <itaru.kitayama@...il.com>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Mark Rutland <mark.rutland@....com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] arm64/mm: Add pud_sect_supported()

On 9/22/21 10:22 AM, Itaru Kitayama wrote:
> How did you test the 16K page size configurations? In QEMU? I wasn't
> aware of hardware that's capable 16KB page size.

FVP (Fixed Virtual Platforms).

> 
> On Wed, Sep 22, 2021 at 1:47 PM Anshuman Khandual
> <anshuman.khandual@....com> wrote:
>>
>>
>>
>> On 9/20/21 9:11 PM, Catalin Marinas wrote:
>>> On Mon, Sep 20, 2021 at 02:59:31PM +0530, Anshuman Khandual wrote:
>>>> Section mapping at PUD level is supported only on 4K pages and currently it
>>>> gets verified with explicit #ifdef or IS_ENABLED() constructs. This adds a
>>>> new helper pud_sect_supported() for this purpose, which particularly cleans
>>>> up the HugeTLB code path. It updates relevant switch statements with checks
>>>> for __PAGETABLE_PMD_FOLDED in order to avoid build failures caused with two
>>>> identical switch case values in those code blocks.
>>>>
>>>> Cc: Catalin Marinas <catalin.marinas@....com>
>>>> Cc: Will Deacon <will@...nel.org>
>>>> Cc: linux-arm-kernel@...ts.infradead.org
>>>> Cc: linux-kernel@...r.kernel.org
>>>> Suggested-by: Mark Rutland <mark.rutland@....com>
>>>> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
>>>
>>> Assuming that you tested the corresponding configurations,
>>
>> Right, I did test this on all page size and VA bits configurations
>> , including the specific ones which were problematic.
>>
>>>
>>> Reviewed-by: Catalin Marinas <catalin.marinas@....com>
>>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives