linux-kernel - Re: [PATCH v2 3/4] nitro_enclaves: add test framework for the misc functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUrFNTQFnFMTVvnm@kroah.com>
Date:   Wed, 22 Sep 2021 07:55:01 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)" 
        <longpeng2@...wei.com>
Cc:     "andraprs@...zon.com" <andraprs@...zon.com>,
        "lexnv@...zon.com" <lexnv@...zon.com>,
        "alcioa@...zon.com" <alcioa@...zon.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Gonglei (Arei)" <arei.gonglei@...wei.com>,
        "kamal@...onical.com" <kamal@...onical.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "sgarzare@...hat.com" <sgarzare@...hat.com>,
        "stefanha@...hat.com" <stefanha@...hat.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "ne-devel-upstream@...zon.com" <ne-devel-upstream@...zon.com>
Subject: Re: [PATCH v2 3/4] nitro_enclaves: add test framework for the misc
 functionality

On Wed, Sep 22, 2021 at 12:33:19AM +0000, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@...uxfoundation.org]
> > Sent: Tuesday, September 21, 2021 11:21 PM
> > To: Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
> > <longpeng2@...wei.com>
> > Cc: andraprs@...zon.com; lexnv@...zon.com; alcioa@...zon.com;
> > linux-kernel@...r.kernel.org; Gonglei (Arei) <arei.gonglei@...wei.com>;
> > kamal@...onical.com; pbonzini@...hat.com; sgarzare@...hat.com;
> > stefanha@...hat.com; vkuznets@...hat.com; ne-devel-upstream@...zon.com
> > Subject: Re: [PATCH v2 3/4] nitro_enclaves: add test framework for the misc
> > functionality
> > 
> > On Tue, Sep 21, 2021 at 11:10:38PM +0800, Longpeng(Mike) wrote:
> > > Add test framework for the misc functionality.
> > 
> > What is "the misc functionality"?
> > 
> 
> The functionalities provided in the ne_misc_dev.c

You need to be more verbose here in this commit message please, so that
everyone can properly understand what is going on.

> 
> > >
> > > Signed-off-by: Longpeng(Mike) <longpeng2@...wei.com>
> > > ---
> > >  drivers/virt/nitro_enclaves/Kconfig        |  8 ++++++++
> > >  drivers/virt/nitro_enclaves/ne_misc_dev.c  | 27
> > +++++++++++++++++++++++++++
> > >  drivers/virt/nitro_enclaves/ne_misc_test.c | 17 +++++++++++++++++
> > >  3 files changed, 52 insertions(+)
> > >  create mode 100644 drivers/virt/nitro_enclaves/ne_misc_test.c
> > 
> > What changed from v1?
> > 
> 
> The unit tests are new added in v2, described in the cover letter.

Ah, the cover letter showed up _after_ these commits did :(

thanks,

greg k-h