linux-kernel - Re: [PATCH stable 5.10 3/3] ARM: 9079/1: ftrace: Add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d374a9ae-2dd0-3b11-d5f8-211ef3a6f991@nokia.com>
Date:   Wed, 22 Sep 2021 08:53:12 +0200
From:   Alexander Sverdlin <alexander.sverdlin@...ia.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sasha Levin <sashal@...nel.org>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        "moderated list:ARM PORT" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH stable 5.10 3/3] ARM: 9079/1: ftrace: Add MODULE_PLTS
 support

Hello Florian,

On 22/09/2021 04:39, Florian Fainelli wrote:
> From: Alex Sverdlin <alexander.sverdlin@...ia.com>
> 
> commit 79f32b221b18c15a98507b101ef4beb52444cc6f upstream
> 
> Teach ftrace_make_call() and ftrace_make_nop() about PLTs.
> Teach PLT code about FTRACE and all its callbacks.

sorry for inconvenience, but I'd propose to add 6fa630bf473827ae
"ARM: 9098/1: ftrace: MODULE_PLT: Fix build problem without DYNAMIC_FTRACE"
to all series on this topic, because of the below chunk which might
lead to build issues on some exotic configurations.

Link: https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/ZUVCQBHDMFVR7CCB7JPESLJEWERZDJ3T/

> --- a/arch/arm/kernel/module-plts.c
> +++ b/arch/arm/kernel/module-plts.c
> @@ -20,19 +21,52 @@
>  						    (PLT_ENT_STRIDE - 8))
>  #endif
>  
> +static const u32 fixed_plts[] = {
> +#ifdef CONFIG_FUNCTION_TRACER
> +	FTRACE_ADDR,
> +	MCOUNT_ADDR,
> +#endif
> +};
> +
>  static bool in_init(const struct module *mod, unsigned long loc)
>  {
>  	return loc - (u32)mod->init_layout.base < mod->init_layout.size;

-- 
Best regards,
Alexander Sverdlin.