linux-kernel - Re: [PATCH 16/16] tty: drop tty_flip_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fd9ed1a-edd2-a154-da1c-022a89b2c722@kernel.org>
Date:   Wed, 22 Sep 2021 08:57:17 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/16] tty: drop tty_flip_buffer_push

On 16. 09. 21, 12:03, Johan Hovold wrote:
> On Tue, Sep 14, 2021 at 11:14:15AM +0200, Jiri Slaby wrote:
>> Since commit a9c3f68f3cd8d (tty: Fix low_latency BUG) in 2014,
>> tty_flip_buffer_push() is only a wrapper to tty_schedule_flip(). All
>> users were converted, so remove tty_flip_buffer_push() completely.
> 
> Did you consider inlining tty_flip_buffer_push() or unexporting
> tty_schedule_flip() instead?

Yes -- I see no reason for two functions doing the very same thing. It's 
only confusing.

> The name tty_flip_buffer_push() is arguable more descriptive since the
> work may already be running and is also less tied to the implementation.
> 
> The ratio of drivers using tty_flip_buffer_push() over
> tty_schedule_flip() is also something like 186 to 15 so that would
> amount to a lot less churn too.

OK, I can do either way. I chose this path as tty_schedule_flip was a 
wrapper to tty_flip_buffer_push. In any case, I wouldn't take the number 
of changed drivers as a measure. But if it makes more sense for people 
regarding the naming, I will "flip" the two flips.

> Also, can you please start adding cover letters to your series to
> provide an overview of what it is you're trying to accomplish?

I am not a fan of cover letters as they are not Cced to people who are 
Cced in separate patches. So what would you like to see in the letter? 
This series are just a random cleanup and IMO there is not much more to 
be said except what is in their commit logs.

thanks,
-- 
js
suse labs