linux-kernel - Re: [PATCH v2 1/3] devfreq: exynos-ppmu: use node names with hyphens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Sep 2021 16:55:37 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Rob Herring <robh+dt@...nel.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>,
        Sylwester Nawrocki <snawrocki@...nel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v2 1/3] devfreq: exynos-ppmu: use node names with hyphens

Hi Krzysztof,

On 21. 9. 20. 오후 4:17, Krzysztof Kozlowski wrote:
> Devicetree naming convention requires device node names to use hyphens
> instead of underscore, so Exynos5422 devfreq event name
> "ppmu-event3-dmc0_0" should be "ppmu-event3-dmc0-0".  Newly introduced
> dtschema enforces this, however the driver still expects old name with
> an underscore.
> 
> Add new events for Exynos5422 while still accepting old name for
> backwards compatibility.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
>   drivers/devfreq/event/exynos-ppmu.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 17ed980d9099..541bd13ab61d 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -94,11 +94,16 @@ static struct __exynos_ppmu_events {
>   	PPMU_EVENT(d1-general),
>   	PPMU_EVENT(d1-rt),
>   
> -	/* For Exynos5422 SoC */
> +	/* For Exynos5422 SoC, deprecated (backwards compatible) */
>   	PPMU_EVENT(dmc0_0),
>   	PPMU_EVENT(dmc0_1),
>   	PPMU_EVENT(dmc1_0),
>   	PPMU_EVENT(dmc1_1),
> +	/* For Exynos5422 SoC */
> +	PPMU_EVENT(dmc0-0),
> +	PPMU_EVENT(dmc0-1),
> +	PPMU_EVENT(dmc1-0),
> +	PPMU_EVENT(dmc1-1),
>   };
>   
>   static int __exynos_ppmu_find_ppmu_id(const char *edev_name)
> 

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi