linux-kernel - Re: [PATCH 2/2] gpio: tps65218: drop unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Sep 2021 12:13:07 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] gpio: tps65218: drop unneeded MODULE_ALIAS

On Thu, Sep 16, 2021 at 6:46 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...onical.com> wrote:
>
> The MODULE_DEVICE_TABLE already creates proper alias for platform
> driver.  Having another MODULE_ALIAS causes the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
>  drivers/gpio/gpio-tps65218.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-tps65218.c
> index 3517debe2b0b..912382be48e1 100644
> --- a/drivers/gpio/gpio-tps65218.c
> +++ b/drivers/gpio/gpio-tps65218.c
> @@ -230,4 +230,3 @@ module_platform_driver(tps65218_gpio_driver);
>  MODULE_AUTHOR("Nicolas Saenz Julienne <nicolassaenzj@...il.com>");
>  MODULE_DESCRIPTION("GPO interface for TPS65218 PMICs");
>  MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("platform:tps65218-gpio");
> --
> 2.30.2
>

Applied, thanks!

Bart