linux-kernel - Re: [PATCH] mac80211_hwsim: enable 6GHz channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <167f632eb19944b5711a584218e57b51da85df96.camel@sipsolutions.net>
Date:   Wed, 22 Sep 2021 16:29:37 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Ramon Fontes <ramonreisfontes@...il.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org
Cc:     kvalo@...eaurora.org, davem@...emloft.net
Subject: Re: [PATCH] mac80211_hwsim: enable 6GHz channels

On Wed, 2021-09-22 at 11:28 -0300, Ramon Fontes wrote:
> This adds 6 GHz capabilities and reject HT/VHT
> 

It'd be nice to add a version to the subject, with -vN on the git-send-
email commandline :)

> +		.he_6ghz_capa = {
> +			.capa = IEEE80211_HE_6GHZ_CAP_MIN_MPDU_START |
> +			        IEEE80211_HE_6GHZ_CAP_MAX_AMPDU_LEN_EXP |
> +			        IEEE80211_HE_6GHZ_CAP_MAX_MPDU_LEN |
> +			        cpu_to_le16(IEEE80211_HE_6GHZ_CAP_TX_ANTPAT_CONS |
> +			        IEEE80211_HE_6GHZ_CAP_RX_ANTPAT_CONS),

Seems that needs to be around the *entire* initializer, not just parts
thereof?

The indentation could also use some work :)

johannes