linux-kernel - Re: [PATCH 4/4] block: cancel all throttled bios in blk_cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUs/CcSKqNoIIXoW@infradead.org>
Date:   Wed, 22 Sep 2021 15:34:49 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Yu Kuai <yukuai3@...wei.com>
Cc:     axboe@...nel.dk, tj@...nel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
        yi.zhang@...wei.com
Subject: Re: [PATCH 4/4] block: cancel all throttled bios in
 blk_cleanup_queue()

On Wed, Sep 22, 2021 at 08:51:15PM +0800, Yu Kuai wrote:
> Throttled bios can't be issued after queue is dying in
> blk_cleanup_queue(), thus it's better to cancel them immediately
> rather than waiting for throttle is done.
> 
> For example, if user thread is throttled with low bps while is
> issuing large io, and the device is deleted. The user thread will
> wait for a long time for io to return.

blk_cleanup_queue is too late, this will need to go into del_gendisk
and on top of my "tear down file system I/O in del_gendisk" series.