lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 17:23:21 +0000 From: Yazen Ghannam <yazen.ghannam@....com> To: "Joshi, Mukul" <Mukul.Joshi@....com> Cc: "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>, "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "bp@...en8.de" <bp@...en8.de>, "mingo@...hat.com" <mingo@...hat.com>, "mchehab@...nel.org" <mchehab@...nel.org>, "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org> Subject: Re: [PATCHv3 2/2] drm/amdgpu: Register MCE notifier for Aldebaran RAS On Thu, Sep 23, 2021 at 11:30:55AM -0400, Joshi, Mukul wrote: ... > > > + return NOTIFY_DONE; > > > + > > > + /* > > > + * If it is correctable error, return. > > > + */ > > > + if (mce_is_correctable(m)) > > > + return NOTIFY_OK; > > > > Shouldn't this be "NOTIFY_DONE" if "don't care" about this error? > > The thinking is we want to stop calling further consumers since it's a correctable error in GPU UMC and we are not taking any action about the correctable errors. Shouldn't the error still be reported to EDAC for decoding and counting? I think users want this. But it looks to me that either NOTIFY_OK or NOTIFY_DONE will allow this, so it's not a big deal. Was this intended to be NOTIFY_STOP? Thanks, Yazen
Powered by blists - more mailing lists