lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 20:13:21 +0200 From: Sven Peter <sven@...npeter.dev> To: Heikki Krogerus <heikki.krogerus@...ux.intel.com> Cc: Sven Peter <sven@...npeter.dev>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Guido Günther <agx@...xcpu.org>, "Bryan O'Donoghue" <bryan.odonoghue@...aro.org>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, Hector Martin <marcan@...can.st>, Mohamed Mediouni <mohamed.mediouni@...amail.com>, Stan Skowronek <stan@...ellium.com>, Mark Kettenis <mark.kettenis@...all.nl>, Alexander Graf <graf@...zon.com>, Alyssa Rosenzweig <alyssa@...enzweig.io> Subject: [PATCH v2 6/6] usb: typec: tipd: Remove FIXME about testing with I2C_FUNC_I2C The Apple i2c bus uses I2C_FUNC_I2C and I've tested this quite extensivly in the past days. Remove the FIXME about that testing :-) Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io> Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com> Signed-off-by: Sven Peter <sven@...npeter.dev> --- changes since v1: - added r-b tags drivers/usb/typec/tipd/core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index 20d9f89208ff..51cebb41884c 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -746,9 +746,6 @@ static int tps6598x_probe(struct i2c_client *client) /* * Checking can the adapter handle SMBus protocol. If it can not, the * driver needs to take care of block reads separately. - * - * FIXME: Testing with I2C_FUNC_I2C. regmap-i2c uses I2C protocol - * unconditionally if the adapter has I2C_FUNC_I2C set. */ if (i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) tps->i2c_protocol = true; -- 2.25.1
Powered by blists - more mailing lists