linux-kernel - Re: [PATCH] arm64: dts: marvell: add Globalscale MOCHAbin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 Sep 2021 20:15:10 +0200
From:   Robert Marko <robert.marko@...tura.hr>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Rob Herring <robh+dt@...nel.org>, gregory.clement@...tlin.com,
        sebastian.hesselbarth@...il.com,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: marvell: add Globalscale MOCHAbin

On Thu, Sep 23, 2021 at 7:32 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> > +     /* 88E6141 Topaz switch */
> > +     switch: switch@3 {
> > +             compatible = "marvell,mv88e6085";
> > +             #address-cells = <1>;
> > +             #size-cells = <0>;
> > +             reg = <3>;
> > +
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&cp0_switch_pins>;
> > +             reset-gpios = <&cp0_gpio1 0 GPIO_ACTIVE_LOW>;
> > +
> > +             interrupt-parent = <&cp0_gpio1>;
> > +             interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
>
> The switch interrupt is a level interrupt, not an edge interrupt.

Hi Andrew,
thanks for catching this.
The same is true for the PCA9554 as well.
Will fix that now in v3.

Regards,
Robert
>
>     Andrew



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@...tura.hr
Web: www.sartura.hr