lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 14:23:38 -0700 From: Edwin Peer <edwin.peer@...adcom.com> To: Leon Romanovsky <leon@...nel.org> Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Leon Romanovsky <leonro@...dia.com>, Alexander Lobakin <alobakin@...me>, Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>, Ariel Elior <aelior@...vell.com>, GR-everest-linux-l2@...vell.com, GR-QLogic-Storage-Upstream@...vell.com, Igor Russkikh <irusskikh@...vell.com>, intel-wired-lan@...ts.osuosl.org, "James E.J. Bottomley" <jejb@...ux.ibm.com>, Javed Hasan <jhasan@...vell.com>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Jiri Pirko <jiri@...dia.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-scsi@...r.kernel.org, "Martin K. Petersen" <martin.petersen@...cle.com>, Michael Chan <michael.chan@...adcom.com>, Michal Kalderon <michal.kalderon@...vell.com>, netdev <netdev@...r.kernel.org>, Sathya Perla <sathya.perla@...adcom.com>, Saurav Kashyap <skashyap@...vell.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, Vasundhara Volam <vasundhara-v.volam@...adcom.com> Subject: Re: [PATCH net-next 2/6] bnxt_en: Properly remove port parameter support On Thu, Sep 23, 2021 at 11:13 AM Leon Romanovsky <leon@...nel.org> wrote: > > From: Leon Romanovsky <leonro@...dia.com> > > This driver doesn't have any port parameters and registers > devlink port parameters with empty table. Remove the useless > calls to devlink_port_params_register and _unregister. > > Fixes: da203dfa89ce ("Revert "devlink: Add a generic wake_on_lan port parameter"") > Signed-off-by: Leon Romanovsky <leonro@...dia.com> > --- > drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > index dc0851f709f5..ed95e28d60ef 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > @@ -736,9 +736,6 @@ static const struct devlink_param bnxt_dl_params[] = { > NULL), > }; > > -static const struct devlink_param bnxt_dl_port_params[] = { > -}; > - > static int bnxt_dl_params_register(struct bnxt *bp) > { > int rc; > @@ -753,14 +750,6 @@ static int bnxt_dl_params_register(struct bnxt *bp) > rc); > return rc; > } > - rc = devlink_port_params_register(&bp->dl_port, bnxt_dl_port_params, > - ARRAY_SIZE(bnxt_dl_port_params)); > - if (rc) { > - netdev_err(bp->dev, "devlink_port_params_register failed\n"); > - devlink_params_unregister(bp->dl, bnxt_dl_params, > - ARRAY_SIZE(bnxt_dl_params)); > - return rc; > - } > devlink_params_publish(bp->dl); > > return 0; > @@ -773,8 +762,6 @@ static void bnxt_dl_params_unregister(struct bnxt *bp) > > devlink_params_unregister(bp->dl, bnxt_dl_params, > ARRAY_SIZE(bnxt_dl_params)); > - devlink_port_params_unregister(&bp->dl_port, bnxt_dl_port_params, > - ARRAY_SIZE(bnxt_dl_port_params)); > } > > int bnxt_dl_register(struct bnxt *bp) > -- > 2.31.1 > Ah, looks like the revert in da203dfa89ce wasn't complete. Thanks for the cleanup. Reviewed-by: Edwin Peer <edwin.peer@...adcom.com> Regards, Edwin Peer
Powered by blists - more mailing lists