lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 14:50:47 -0700 From: Nathan Chancellor <nathan@...nel.org> To: Sanket Goswami <Sanket.Goswami@....com> Cc: Shyam-sundar.S-k@....com, hdegoede@...hat.com, mgross@...ux.intel.com, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] platform/x86: amd-pmc: Export Idlemask values based on the APU On Thu, Sep 16, 2021 at 06:10:02PM +0530, Sanket Goswami wrote: > IdleMask is the metric used by the PM firmware to know the status of each > of the Hardware IP blocks monitored by the PM firmware. > > Knowing this value is key to get the information of s2idle suspend/resume > status. This value is mapped to PMC scratch registers, retrieve them > accordingly based on the CPU family and the underlying firmware support. > > Co-developed-by: Shyam Sundar S K <Shyam-sundar.S-k@....com> > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@....com> > Signed-off-by: Sanket Goswami <Sanket.Goswami@....com> This patch as commit f6045de1f532 ("platform/x86: amd-pmc: Export Idlemask values based on the APU") in -next causes the following errors when CONFIG_DEBUG_FS is disabled: drivers/platform/x86/amd-pmc.c:424:2: error: implicit declaration of function 'amd_pmc_idlemask_read' [-Werror,-Wimplicit-function-declaration] amd_pmc_idlemask_read(pdev, dev, NULL); ^ drivers/platform/x86/amd-pmc.c:424:2: note: did you mean 'amd_pmc_reg_read'? drivers/platform/x86/amd-pmc.c:131:19: note: 'amd_pmc_reg_read' declared here static inline u32 amd_pmc_reg_read(struct amd_pmc_dev *dev, int reg_offset) ^ drivers/platform/x86/amd-pmc.c:448:2: error: implicit declaration of function 'amd_pmc_idlemask_read' [-Werror,-Wimplicit-function-declaration] amd_pmc_idlemask_read(pdev, dev, NULL); ^ drivers/platform/x86/amd-pmc.c:536:2: error: implicit declaration of function 'amd_pmc_get_smu_version' [-Werror,-Wimplicit-function-declaration] amd_pmc_get_smu_version(dev); ^ 3 errors generated. Should these functions be stubbed or should there be a different fix? Cheers, Nathan
Powered by blists - more mailing lists