linux-kernel - Re: [PATCH v5 1/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 Sep 2021 19:12:20 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-iio@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 1/3] iio: imx8qxp-adc: Add driver support for NXP
 IMX8QXP ADC

Hi Cai,

On Tue, Sep 21, 2021 at 2:29 AM Cai Huoqing <caihuoqing@...du.com> wrote:

> +error_iio_device_register:
> +       clk_disable_unprepare(adc->ipg_clk);
> +error_adc_ipg_clk_enable:
> +       clk_disable_unprepare(adc->clk);
> +error_adc_clk_enable:
> +       regulator_disable(adc->vref);

Please rename these labels to indicate the action that will be performed.

Something like this:

error_ipg_clk_disable:
       clk_disable_unprepare(adc->ipg_clk);
error_adc_clk_disable:
       clk_disable_unprepare(adc->clk);
error_regulator_disable:
       regulator_disable(adc->vref);