lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 09:45:51 +0300 From: Leon Romanovsky <leon@...nel.org> To: Bart Van Assche <bvanassche@....org> Cc: "Marciniszyn, Mike" <mike.marciniszyn@...nelisnetworks.com>, Guo Zhi <qtxuning1999@...u.edu.cn>, "Dalessandro, Dennis" <dennis.dalessandro@...nelisnetworks.com>, "dledford@...hat.com" <dledford@...hat.com>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c On Wed, Sep 22, 2021 at 11:05:42AM -0700, Bart Van Assche wrote: > On 9/22/21 10:51 AM, Marciniszyn, Mike wrote: > > > Subject: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c > > > > > > Pointers should be printed with %p or %px rather than cast to (unsigned long > > > long) and printed with %llx. > > > Change %llx to %p to print the pointer. > > > > > > Signed-off-by: Guo Zhi <qtxuning1999@...u.edu.cn> > > > > The unsigned long long was originally used to insure the entire accurate pointer as emitted. > > > > This is to ensure the pointers in prints and event traces match values in stacks and register dumps. > > > > I think the %p will obfuscate the pointer so %px is correct for our use case. > > How about applying Guo's patch and adding a configuration option to the > kernel for disabling pointer hashing for %p and related format specifiers? Isn't kptr_restrict sysctl is for that? > Pointer hashing is useful on production systems but not on development > systems. > > Thanks, > > Bart. >
Powered by blists - more mailing lists