linux-kernel - Re: [PATCH v8 10/16] i915/gvt: remove spaces in pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210923073659.GZ14689@zhen-hp.sh.intel.com>
Date:   Thu, 23 Sep 2021 15:36:59 +0800
From:   Zhenyu Wang <zhenyuw@...ux.intel.com>
To:     Jim Cromie <jim.cromie@...il.com>
Cc:     jbaron@...mai.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, intel-gvt-dev@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org, daniel@...ll.ch
Subject: Re: [PATCH v8 10/16] i915/gvt: remove spaces in pr_debug "gvt:
 core:" etc prefixes

On 2021.09.15 10:39:51 -0600, Jim Cromie wrote:
> Taking embedded spaces out of existing prefixes makes them better
> class-prefixes; simplifying the extra quoting needed otherwise:
> 
>   $> echo format "^gvt: core:" +p >control
> 
> Dropping the internal spaces means any trailing space in a query will
> more clearly terminate the prefix being searched for.
> 
> Consider a generic drm-debug example:
> 
>   # turn off ATOMIC reports
>   echo format "^drm:atomic: " -p > control
> 
>   # turn off all ATOMIC:* reports, including any sub-categories
>   echo format "^drm:atomic:" -p > control
> 
>   # turn on ATOMIC:FAIL: reports
>   echo format "^drm:atomic:fail: " +p > control
> 
> Removing embedded spaces in the class-prefixes simplifies the
> corresponding match-prefix.  This means that "quoted" match-prefixes
> are only needed when the trailing space is desired, in order to
> exclude explicitly sub-categorized pr-debugs; in this example,
> "drm:atomic:fail:".
> 
> RFC: maybe the prefix catenation should paste in the " " class-prefix
> terminator explicitly.  A pr_debug_() flavor could exclude the " ",
> allowing ad-hoc sub-categorization by appending for example, "fail:"
> to "drm:atomic:" without the default " " insertion.
> 
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
> v8:
> . fix patchwork CI warning
> ---
>  drivers/gpu/drm/i915/gvt/debug.h | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/debug.h b/drivers/gpu/drm/i915/gvt/debug.h
> index c6027125c1ec..bbecc279e077 100644
> --- a/drivers/gpu/drm/i915/gvt/debug.h
> +++ b/drivers/gpu/drm/i915/gvt/debug.h
> @@ -36,30 +36,30 @@ do {									\
>  } while (0)
>  
>  #define gvt_dbg_core(fmt, args...) \
> -	pr_debug("gvt: core: "fmt, ##args)
> +	pr_debug("gvt:core: " fmt, ##args)
>  
>  #define gvt_dbg_irq(fmt, args...) \
> -	pr_debug("gvt: irq: "fmt, ##args)
> +	pr_debug("gvt:irq: " fmt, ##args)
>  
>  #define gvt_dbg_mm(fmt, args...) \
> -	pr_debug("gvt: mm: "fmt, ##args)
> +	pr_debug("gvt:mm: " fmt, ##args)
>  
>  #define gvt_dbg_mmio(fmt, args...) \
> -	pr_debug("gvt: mmio: "fmt, ##args)
> +	pr_debug("gvt:mmio: " fmt, ##args)
>  
>  #define gvt_dbg_dpy(fmt, args...) \
> -	pr_debug("gvt: dpy: "fmt, ##args)
> +	pr_debug("gvt:dpy: " fmt, ##args)
>  
>  #define gvt_dbg_el(fmt, args...) \
> -	pr_debug("gvt: el: "fmt, ##args)
> +	pr_debug("gvt:el: " fmt, ##args)
>  
>  #define gvt_dbg_sched(fmt, args...) \
> -	pr_debug("gvt: sched: "fmt, ##args)
> +	pr_debug("gvt:sched: " fmt, ##args)
>  
>  #define gvt_dbg_render(fmt, args...) \
> -	pr_debug("gvt: render: "fmt, ##args)
> +	pr_debug("gvt:render: " fmt, ##args)
>  
>  #define gvt_dbg_cmd(fmt, args...) \
> -	pr_debug("gvt: cmd: "fmt, ##args)
> +	pr_debug("gvt:cmd: " fmt, ##args)
>  
>  #endif
> -- 

Looks good to me. Thanks!

Reviewed-by: Zhenyu Wang <zhenyuw@...ux.intel.com>

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)