linux-kernel - Re: [PATCH 6/8] staging: r8188eu: remove dead code from rtl8188e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 Sep 2021 11:31:47 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, martin@...ser.cx, fmdefrancesco@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/8] staging: r8188eu: remove dead code from
 rtl8188e_rf6052.c

On Thu, Sep 23, 2021 at 10:21:34AM +0200, Michael Straube wrote:
> On 9/23/21 09:29, Dan Carpenter wrote:
> > On Tue, Sep 21, 2021 at 09:46:56PM +0200, Michael Straube wrote:
> > > In this driver DynamicTxHighPowerLvl is set to TxHighPwrLevel_Normal
> > > and never changed. In the file rtl8188e_rf6052.c there are some if
> > > statements that check DynamicTxHighPowerLvl for other values than
> > > TxHighPwrLevel_Normal. The code in the if blocks is never executed.
> > > Remove the dead code.
> > > 
> > > Signed-off-by: Michael Straube <straube.linux@...il.com>
> > > ---
> > >   drivers/staging/r8188eu/hal/rtl8188e_rf6052.c | 57 +++++--------------
> > >   1 file changed, 14 insertions(+), 43 deletions(-)
> > > 
> > > diff --git a/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c b/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
> > > index edaa9a6dfdb1..946a1b97d96f 100644
> > > --- a/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
> > > +++ b/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
> > > @@ -85,7 +85,6 @@ rtl8188e_PHY_RF6052SetCckTxPower(
> > >   		u8 *pPowerlevel)
> > >   {
> > >   	struct hal_data_8188e *pHalData = GET_HAL_DATA(Adapter);
> > > -	struct dm_priv *pdmpriv = &pHalData->dmpriv;
> > >   	struct mlme_ext_priv *pmlmeext = &Adapter->mlmeextpriv;
> > >   	u32 TxAGC[2] = {0, 0}, tmpval = 0, pwrtrac_value;
> > >   	bool TurboScanOff = false;
> > > @@ -112,34 +111,19 @@ rtl8188e_PHY_RF6052SetCckTxPower(
> > >   			}
> > >   		}
> > >   	} else {
> > > -		/* Driver dynamic Tx power shall not affect Tx power.
> > > -		 * It shall be determined by power training mechanism.
> > > -i		 *  Currently, we cannot fully disable driver dynamic
> >     ^
> > 
> > You're a vimster.  :)
> > 
> 
> Not really, actually this was part of the original code. ;)

Huh...  Alright then.  Someone else was a vimster.  Good that you're
deleting their mistakes!

regards,
dan carpenter