linux-kernel - Re: [PATCH] EDAC/al-mc-edac: Make use of the helper function devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb981992-a44f-d2d2-9c6d-31c5d53c74c1@amazon.com>
Date:   Thu, 23 Sep 2021 11:50:16 +0300
From:   "Shenhar, Talel" <talel@...zon.com>
To:     Cai Huoqing <caihuoqing@...du.com>
CC:     Borislav Petkov <bp@...en8.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>,
        Ronen Krupnik <ronenk@...zon.com>,
        <linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <talelshenhar@...il.com>
Subject: Re: [PATCH] EDAC/al-mc-edac: Make use of the helper function
 devm_add_action_or_reset()


> The helper function devm_add_action_or_reset() will internally
> call devm_add_action(), and if devm_add_action() fails then it will
> execute the action mentioned and return the error code. So
> use devm_add_action_or_reset() instead of devm_add_action()
> to simplify the error handling, reduce the code.
>
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
Acked-by: Talel Shenhar <talel@...zon.com>
> ---
>   drivers/edac/al_mc_edac.c | 12 ++++--------
>   1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/edac/al_mc_edac.c b/drivers/edac/al_mc_edac.c
> index 7d4f396c27b5..178b9e581a72 100644
> --- a/drivers/edac/al_mc_edac.c
> +++ b/drivers/edac/al_mc_edac.c
> @@ -238,11 +238,9 @@ static int al_mc_edac_probe(struct platform_device *pdev)
>          if (!mci)
>                  return -ENOMEM;
>
> -       ret = devm_add_action(&pdev->dev, devm_al_mc_edac_free, mci);
> -       if (ret) {
> -               edac_mc_free(mci);
> +       ret = devm_add_action_or_reset(&pdev->dev, devm_al_mc_edac_free, mci);
> +       if (ret)
>                  return ret;
> -       }
>
>          platform_set_drvdata(pdev, mci);
>          al_mc = mci->pvt_info;
> @@ -293,11 +291,9 @@ static int al_mc_edac_probe(struct platform_device *pdev)
>                  return ret;
>          }
>
> -       ret = devm_add_action(&pdev->dev, devm_al_mc_edac_del, &pdev->dev);
> -       if (ret) {
> -               edac_mc_del_mc(&pdev->dev);
> +       ret = devm_add_action_or_reset(&pdev->dev, devm_al_mc_edac_del, &pdev->dev);
> +       if (ret)
>                  return ret;
> -       }
>
>          if (al_mc->irq_ue > 0) {
>                  ret = devm_request_irq(&pdev->dev,
> --
> 2.25.1
>