lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 17:02:32 +0800 From: <yipeng.chen@....com> To: <harry.wentland@....com>, <sunpeng.li@....com>, <alexander.deucher@....com>, <christian.koenig@....com>, <airlied@...ux.ie>, <daniel@...ll.ch>, <qingqing.zhuo@....com>, <Aric.Cyr@....com>, <Anson.Jacob@....com>, <bindu.r@....com>, <martin.tsai@....com>, <bing.guo@....com>, <roy.chan@....com>, <george.shen@....com>, <joshua.aberback@....com>, <Ashley.Thomas2@....com>, <Jing.Zhou@....com>, <dale.zhao@....com> CC: <amd-gfx@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>, "Yipeng Chen (Jasber)" <yipeng.chen@....com>, Roman Li <Roman.Li@....com> Subject: [PATCH] drm/amd/display: Fix randomly flicking on overlay with enabled ABM From: "Yipeng Chen (Jasber)" <yipeng.chen@....com> [Why] Enabled ABM (level != 0) would raise short pluse irq DC_IRQ_SOURCE_HPD1RX randomly with PSR error LINK_CRC_ERROR. Actually there is no hot plugging on EDP panel. After correcting CRC error, there is no need to send drm hotplug event. [How] Returning false would skip doing hot-plug when handle_hpd_irq_psr_sink() handled irq. Hot-plug process causes visible flicking on overlay. Signed-off-by: Yipeng Chen (Jasber) <yipeng.chen@....com> Reviewed-by: Roman Li <Roman.Li@....com> Anthony Koo <Anthony.Koo@....com> --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index 1e4794e2825c..9b9fbe5e9bd4 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c @@ -3007,7 +3007,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd if (handle_hpd_irq_psr_sink(link)) /* PSR-related error was detected and handled */ - return true; + return false; /* If PSR-related error handled, Main link may be off, * so do not handle as a normal sink status change interrupt. -- 2.25.1
Powered by blists - more mailing lists