lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 09:42:10 +0000 From: Shahab Vahedi <Shahab.Vahedi@...opsys.com> To: Randy Dunlap <rdunlap@...radead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: Vineet Gupta <vgupta@...nel.org>, "linux-snps-arc@...ts.infradead.org" <linux-snps-arc@...ts.infradead.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH] clocksource: arc_timer: eliminate redefined macro error Hi Randy, I have one minor comment. On 9/23/21 5:18 AM, Randy Dunlap wrote: > > --- linux-next-20210917.orig/include/soc/arc/timers.h > +++ linux-next-20210917/include/soc/arc/timers.h > @@ -17,7 +17,7 @@ > #define ARC_REG_TIMER1_CNT 0x100 /* timer 1 count */ > > /* CTRL reg bits */ > -#define TIMER_CTRL_IE (1 << 0) /* Interrupt when Count reaches limit */ > +#define TIMER_CTRL_IEN (1 << 0) /* Interrupt when Count reaches limit */ Could you change the name to "ARC_TIMER_CTRL_IE" instead? and while at it, please rename "TIMER_CTRL_NH" to "ARC_TIMER_CTRL_NH" for obvious consistency reasons and saving us from future clashes. Thank you! -- Shahab
Powered by blists - more mailing lists