linux-kernel - Re: [PATCH V9 4/8] arm64: dts: sc7280: Add QUPv3 wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ac4e619e5269efc04c9160710d506de@codeaurora.org>
Date:   Thu, 23 Sep 2021 15:43:22 +0530
From:   rajpat@...eaurora.org
To:     Doug Anderson <dianders@...omium.org>
Cc:     Stephen Boyd <swboyd@...omium.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>,
        msavaliy@....qualcomm.com, satya priya <skakit@...eaurora.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Roja Rani Yarubandi <rojay@...eaurora.org>
Subject: Re: [PATCH V9 4/8] arm64: dts: sc7280: Add QUPv3 wrapper_0 nodes

On 2021-09-22 20:24, Doug Anderson wrote:
> Hi,
> 
> On Wed, Sep 22, 2021 at 5:31 AM <rajpat@...eaurora.org> wrote:
>> 
>> >> +                       spi0: spi@...000 {
>> >> +                               compatible = "qcom,geni-spi";
>> >> +                               reg = <0 0x00980000 0 0x4000>;
>> >> +                               clocks = <&gcc
>> >> GCC_QUPV3_WRAP0_S0_CLK>;
>> >> +                               clock-names = "se";
>> >> +                               pinctrl-names = "default";
>> >> +                               pinctrl-0 = <&qup_spi0_data_clk>,
>> >> <&qup_spi0_cs>, <&qup_spi0_cs_gpio>;
>> >
>> > This should only have qup_spi0_data_clk and qup_spi0_cs, not
>> > qup_spi0_cs_gpio. Both qup controlled and gpio controlled options are
>> > provided in case a board wants to use the qup version of chipselect,
>> > but
>> > having them both used by default leads to conflicts and confusion. This
>> > same comment applies to all spi pinctrl properties in this file. Please
>> > keep the cs_gpio variants though so that boards can use them if they
>> > want. They will be unused, but that's OK.
>> 
>> Okay. Shall we remove only "<&qup_spiN_cs_gpio>" in each SPI node?
> 
> Right. So for this one:
> 
> pinctrl-0 = <&qup_spi0_data_clk>, <&qup_spi0_cs>;
> 
> -Doug

Okay.