lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 12:54:04 +0200 From: Andreas Kemnade <andreas@...nade.info> To: Krzysztof Kozlowski <krzk@...nel.org> Cc: robh+dt@...nel.org, Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>, soc@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com, linux-imx@....com, leoyang.li@....com, devicetree@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 3/4] ARM: dts: imx: add devicetree for Kobo Libra H2O Hi, On Thu, 23 Sep 2021 08:26:58 +0200 Krzysztof Kozlowski <krzk@...nel.org> wrote: > On Wed, 22 Sept 2021 at 22:38, Andreas Kemnade <andreas@...nade.info> wrote: > > > > Hi, > > > > On Wed, 22 Sep 2021 09:41:39 +0200 > > Krzysztof Kozlowski <krzk@...nel.org> wrote: > > > > [...] > > > > + pinctrl_usdhc1_100mhz: usdhc1grp_100mhz { > > > > > > Thanks for the patch. > > > > > > This does not look like passing the schema validation. Please run > > > dtbs_check. The node names should use hyphens and end with "grp" > > > suffix. This remark applies to other cases below. > > > > > dtbs_check reports a lot of errors originating from imx6sll.dtsi and > > friends. But nothing added by me. But yes, node names should use > > hyphens, that is documented. I will fix that. > > > > But having -grp at the end for these things with a frequency in the > > name is uncommon. > > $ grep -R :.*100mhz arch/arm/boot/dts/imx6s*.dts > > arch/arm/boot/dts/imx6sl-evk.dts: pinctrl_usdhc1_100mhz: usdhc1grp100mhz { > > arch/arm/boot/dts/imx6sl-evk.dts: pinctrl_usdhc2_100mhz: usdhc2grp100mhz { > > arch/arm/boot/dts/imx6sl-evk.dts: pinctrl_usdhc3_100mhz: usdhc3grp100mhz { > > arch/arm/boot/dts/imx6sll-evk.dts: pinctrl_usdhc1_100mhz: usdhc1grp_100mhz { > > arch/arm/boot/dts/imx6sll-evk.dts: pinctrl_usdhc3_100mhz: usdhc3grp_100mhz { > > arch/arm/boot/dts/imx6sll-kobo-clarahd.dts: pinctrl_usdhc2_100mhz: usdhc2grp-100mhz { > > arch/arm/boot/dts/imx6sll-kobo-clarahd.dts: pinctrl_usdhc3_100mhz: usdhc3grp-100mhz { > > arch/arm/boot/dts/imx6sll-kobo-librah2o.dts: pinctrl_usdhc1_100mhz: usdhc1grp-100mhz { > > arch/arm/boot/dts/imx6sll-kobo-librah2o.dts: pinctrl_usdhc3_100mhz: usdhc3grp_100mhz { > > arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts: pinctrl_usdhc2_100mhz: usdhc2grp-100mhz { > > arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts: pinctrl_usdhc3_100mhz: usdhc3grp-100mhz { > > arch/arm/boot/dts/imx6sl-tolino-shine3.dts: pinctrl_usdhc2_100mhz: usdhc2grp-100mhz { > > arch/arm/boot/dts/imx6sl-tolino-shine3.dts: pinctrl_usdhc3_100mhz: usdhc3grp-100mhz { > > arch/arm/boot/dts/imx6sl-tolino-vision5.dts: pinctrl_usdhc1_100mhz: usdhc1grp-100mhz { > > arch/arm/boot/dts/imx6sl-tolino-vision5.dts: pinctrl_usdhc3_100mhz: usdhc3grp-100mhz { > > arch/arm/boot/dts/imx6sl-warp.dts: pinctrl_usdhc2_100mhz: usdhc2grp100mhz { > > arch/arm/boot/dts/imx6sl-warp.dts: pinctrl_usdhc3_100mhz: usdhc3grp100mhz { > > arch/arm/boot/dts/imx6sx-nitrogen6sx.dts: pinctrl_usdhc4_100mhz: usdhc4-100mhzgrp { > > arch/arm/boot/dts/imx6sx-sabreauto.dts: pinctrl_usdhc3_100mhz: usdhc3grp-100mhz { > > arch/arm/boot/dts/imx6sx-softing-vining-2000.dts: pinctrl_usdhc2_100mhz: usdhc2grp-100mhz { > > arch/arm/boot/dts/imx6sx-softing-vining-2000.dts: pinctrl_usdhc4_100mhz: usdhc4-100mhz { > > I was fixing primarily arm64 boards and did not touch that many of armv7: > grep -R :.*100mhz.*grp arch/arm64/boot/dts/freescale/* | wc -l > 46 > I will send a v2 with the 100mhz style used there. I will not clean up dtbs_check issues originating from imx6sl[l].dtsi in this series. That would be an issue for a separate series. Regards, Andreas
Powered by blists - more mailing lists