linux-kernel - Re: [PATCH 3/3] perf tests: Improve temp file cleanup in test_arm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210923011807.GC400258@leoy-ThinkPad-X240s>
Date:   Thu, 23 Sep 2021 09:18:07 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     James Clark <james.clark@....com>
Cc:     acme@...nel.org, leo.yan@...aro.com,
        linux-perf-users@...r.kernel.org,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] perf tests: Improve temp file cleanup in
 test_arm_coresight.sh

On Wed, Sep 22, 2021 at 05:49:55PM +0100, James Clark wrote:

[...]

> > So below change should be sufficient?
> > 
> > cleanup_files()
> > {
> > 	rm -f ${perfdata}
> > 	rm -f ${file}
> > +       rm -f "${perfdata}.old"
> > +       exit $glb_err
> > }
> > 
> > Sorry if I miss anything at here and cause noise.
> 
> The problem with not re-sending the sigint is that if you want to run the
> script in a bash while loop like:
> 
>   while ! tests/shell/test_arm_coresight.sh; do echo loop; done
> 
> Then it's impossible to exit with Ctrl-C and delete the temp files at the
> same time. It exits if we don't trap sigint like it is at the moment, but
> then it leaves the temporary files. This change is so we can have both
> behaviours of Ctrl-C in a loop and keep the cleanup working.

Okay, I cannot think out better idea to handle this test case;
so current patch is fine for me.  Thanks for explanation.

Thanks,
Leo