linux-kernel - RE: [PATCH] infiniband hfi1: fix misuse of %x in ipoib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH0PR01MB71536B15C0911AFDE910E559F2A39@CH0PR01MB7153.prod.exchangelabs.com>
Date:   Thu, 23 Sep 2021 12:18:46 +0000
From:   "Marciniszyn, Mike" <mike.marciniszyn@...nelisnetworks.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     Bart Van Assche <bvanassche@....org>,
        Guo Zhi <qtxuning1999@...u.edu.cn>,
        "Dalessandro, Dennis" <dennis.dalessandro@...nelisnetworks.com>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c

> > >
> >
> > It doesn't look like that works in irqs, softirqs.
> 
> Are you certain about it?
> 
> That sysctl is supposed to control the output of %p, nothing more.
> 

Actually I think is controls %pK.

The code here is what I was referring to.

		/*
		 * kptr_restrict==1 cannot be used in IRQ context
		 * because its test for CAP_SYSLOG would be meaningless.
		 */
		if (in_irq() || in_serving_softirq() || in_nmi()) {
			if (spec.field_width == -1)
				spec.field_width = 2 * sizeof(ptr);
			return error_string(buf, end, "pK-error", spec);
		}

Mike