lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 13:22:16 +0100 From: Jon Hunter <jonathanh@...dia.com> To: Akhil R <akhilrajeev@...dia.com> CC: "dan.j.williams@...el.com" <dan.j.williams@...el.com>, "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>, Krishna Yarlagadda <kyarlagadda@...dia.com>, Laxman Dewangan <ldewangan@...dia.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, Rajesh Gumasta <rgumasta@...dia.com>, "thierry.reding@...il.com" <thierry.reding@...il.com>, "vkoul@...nel.org" <vkoul@...nel.org>, Pavan Kunapuli <pkunapuli@...dia.com> Subject: Re: [PATCH v6 2/4] dmaengine: tegra: Add tegra gpcdma driver On 22/09/2021 15:46, Akhil R wrote: > >> On 17/09/2021 15:11, Akhil R wrote: >>> +static int tegra_dma_slave_config(struct dma_chan *dc, >>> + struct dma_slave_config *sconfig) { >>> + struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc); >>> + >>> + if (tdc->dma_desc) { >>> + dev_err(tdc2dev(tdc), "Configuration not allowed\n"); >>> + return -EBUSY; >>> + } >>> + >>> + memcpy(&tdc->dma_sconfig, sconfig, sizeof(*sconfig)); >>> + if (tdc->slave_id == -1) >>> + tdc->slave_id = sconfig->slave_id; >>> + >>> + tdc->config_init = true; >>> + return 0; >>> +} >> >> So you have a function to reserve a slave ID, but you don't check here if it is >> already reserved. > slave-id is reserved considering the direction as well. > 'direction' is available only during prep_slave_sg function, I guess. Sorry I don't understand what you mean by that. Jon -- nvpublic
Powered by blists - more mailing lists