linux-kernel - Re: [PATCH v2 3/3] ARM: dts: exynos: align PPMU event node names with dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Sep 2021 11:22:20 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Rob Herring <robh+dt@...nel.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>,
        Sylwester Nawrocki <snawrocki@...nel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v2 3/3] ARM: dts: exynos: align PPMU event node names
 with dtschema

Hi Krzysztof,

On 9/20/21 4:17 PM, Krzysztof Kozlowski wrote:
> Use hyphen instead of underscore and align the PPMU event node name with
> dtschema.  The event-name property must match the node name, by the
> design of devfreq events and PPMU driver.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index e23e8ffb093f..b2f30bea96ce 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -302,8 +302,8 @@ ppmu_dmc0_0: ppmu@...00000 {
>  			clocks = <&clock CLK_PCLK_PPMU_DREX0_0>;
>  			clock-names = "ppmu";
>  			events {
> -				ppmu_event3_dmc0_0: ppmu-event3-dmc0_0 {
> -					event-name = "ppmu-event3-dmc0_0";
> +				ppmu_event3_dmc0_0: ppmu-event3-dmc0-0 {
> +					event-name = "ppmu-event3-dmc0-0";
>  				};
>  			};
>  		};
> @@ -314,8 +314,8 @@ ppmu_dmc0_1: ppmu@...10000 {
>  			clocks = <&clock CLK_PCLK_PPMU_DREX0_1>;
>  			clock-names = "ppmu";
>  			events {
> -				ppmu_event3_dmc0_1: ppmu-event3-dmc0_1 {
> -					event-name = "ppmu-event3-dmc0_1";
> +				ppmu_event3_dmc0_1: ppmu-event3-dmc0-1 {
> +					event-name = "ppmu-event3-dmc0-1";
>  				};
>  			};
>  		};
> @@ -326,8 +326,8 @@ ppmu_dmc1_0: ppmu@...60000 {
>  			clocks = <&clock CLK_PCLK_PPMU_DREX1_0>;
>  			clock-names = "ppmu";
>  			events {
> -				ppmu_event3_dmc1_0: ppmu-event3-dmc1_0 {
> -					event-name = "ppmu-event3-dmc1_0";
> +				ppmu_event3_dmc1_0: ppmu-event3-dmc1-0 {
> +					event-name = "ppmu-event3-dmc1-0";
>  				};
>  			};
>  		};
> @@ -338,8 +338,8 @@ ppmu_dmc1_1: ppmu@...70000 {
>  			clocks = <&clock CLK_PCLK_PPMU_DREX1_1>;
>  			clock-names = "ppmu";
>  			events {
> -				ppmu_event3_dmc1_1: ppmu-event3-dmc1_1 {
> -					event-name = "ppmu-event3-dmc1_1";
> +				ppmu_event3_dmc1_1: ppmu-event3-dmc1-1 {
> +					event-name = "ppmu-event3-dmc1-1";
>  				};
>  			};
>  		};
> 

Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics