linux-kernel - Re: [PATCH] erofs: fix misbehavior of unsupported chunk format check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210923151919.GC1852@hsiangkao-HP-ZHAN-66-Pro-G1>
Date:   Thu, 23 Sep 2021 23:19:20 +0800
From:   Gao Xiang <xiang@...nel.org>
To:     Chao Yu <chao@...nel.org>
Cc:     Gao Xiang <hsiangkao@...ux.alibaba.com>,
        linux-erofs@...ts.ozlabs.org, Liu Bo <bo.liu@...ux.alibaba.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] erofs: fix misbehavior of unsupported chunk format check

On Thu, Sep 23, 2021 at 11:09:25PM +0800, Chao Yu wrote:
> On 2021/9/22 17:51, Gao Xiang wrote:
> > Unsupported chunk format should be checked with
> > "if (vi->chunkformat & ~EROFS_CHUNK_FORMAT_ALL)"
> > 
> > Found when checking with 4k-byte blockmap (although currently mkfs
> 
> That means for 4k-byte blockmap, chunkformat should be zero, right?

Yeah, correct. It's a regression of 4kb chunk blockmap..

> 
> > uses inode chunk indexes format by default.)
> > 
> > Fixes: c5aa903a59db ("erofs: support reading chunk-based uncompressed files")
> > Cc: Liu Bo <bo.liu@...ux.alibaba.com>
> > Cc: Chao Yu <chao@...nel.org>
> > Signed-off-by: Gao Xiang <hsiangkao@...ux.alibaba.com>
> 
> Reviewed-by: Chao Yu <chao@...nel.org>

Thanks!

Thanks,
Gao Xiang

> 
> Thanks,