linux-kernel - Re: [PATCH v2] fs/ntfs3: Remove deprecated mount options nls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 23 Sep 2021 19:12:52 +0300
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Kari Argillander <kari.argillander@...il.com>,
        <ntfs3@...ts.linux.dev>
CC:     <linux-kernel@...r.kernel.org>,
        Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH v2] fs/ntfs3: Remove deprecated mount options nls



On 21.09.2021 20:19, Kari Argillander wrote:
> Some discussion has been spoken that this deprecated mount options
> should be removed before 5.15 lands. This driver is not never seen day
> light so it was decided that nls mount option has to be removed. We have
> always possibility to add this if needed.
> 
> One possible need is example if current ntfs driver will be taken out of
> kernel and ntfs3 needs to support mount options what it has.
> 
> Signed-off-by: Kari Argillander <kari.argillander@...il.com>
> ---
> Patch is compile and checkpatch tested.
> 
> v2:
> 	-Do not delete {}
> ---
>  fs/ntfs3/super.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
> index 6a535b144ff9..800897777eb0 100644
> --- a/fs/ntfs3/super.c
> +++ b/fs/ntfs3/super.c
> @@ -246,10 +246,6 @@ static const struct fs_parameter_spec ntfs_fs_parameters[] = {
>  	fsparam_flag_no("prealloc",		Opt_prealloc),
>  	fsparam_flag_no("acsrules",		Opt_noacsrules),
>  	fsparam_string("iocharset",		Opt_iocharset),
> -
> -	__fsparam(fs_param_is_string,
> -		  "nls", Opt_iocharset,
> -		  fs_param_deprecated, NULL),
>  	{}
>  };
>  
> 
> base-commit: 6354467245ff8dd04b54e39790f2ee4d21d5419e
> 

Applied, thanks!