linux-kernel - Re: [PATCH] serial: 8250: allow disabling of Freescale 16550 compile test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Sep 2021 17:14:38 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250: allow disabling of Freescale 16550 compile test

On Fri, Sep 24, 2021 at 4:13 PM Johan Hovold <johan@...nel.org> wrote:
> The SERIAL_8250_FSL option is used to enable a workaround for a
> break-detection erratum for Freescale 16550 UARTs in the 8250 driver and
> is currently also used to enable support for ACPI enumeration.
>
> It is enabled on PPC, ARM and ARM64 whenever 8250 console support is
> enabled (since the quirk is needed for sysrq handling).
>
> Commit b1442c55ce89 ("serial: 8250: extend compile-test coverage")
> enabled compile testing of the code in question but did not provide a
> means to disable the option when COMPILE_TEST is enabled.
>
> Add a conditional input prompt instead so that SERIAL_8250_FSL is no
> longer enabled by default when compile testing while continuing to
> always enable the quirk for platforms that may need it.
>
> Fixes: b1442c55ce89 ("serial: 8250: extend compile-test coverage")
> Reported-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds