linux-kernel - Re: [PATCH 2/6] ptrace: Remove the unnecessary arguments from arch_ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202109240824.2B4C0B7EC@keescook>
Date:   Fri, 24 Sep 2021 08:26:10 -0700
From:   Kees Cook <keescook@...omium.org>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Al Viro <viro@...iv.linux.org.uk>, linux-api@...r.kernel.org
Subject: Re: [PATCH 2/6] ptrace: Remove the unnecessary arguments from
 arch_ptrace_stop

On Thu, Sep 23, 2021 at 07:10:03PM -0500, Eric W. Biederman wrote:
> 
> Both arch_ptrace_stop_needed and arch_ptrace_stop are called with an
> exit_code and a siginfo structure.  Neither argument is used by any of
> the implementations so just remove the unneeded arguments.
> 
> The two arechitectures that implement arch_ptrace_stop are ia64 and
> sparc.  Both architectures flush their register stacks before a
> ptrace_stack so that all of the register information can be accessed
> by debuggers.
> 
> As the question of if a register stack needs to be flushed is
> independent of why ptrace is stopping not needing arguments make sense.
> 
> Cc: David Miller <davem@...emloft.net>
> Cc: sparclinux@...r.kernel.org
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Yeah, this is a no-op change. No one is using the arguments, as you say.

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

-- 
Kees Cook