linux-kernel - Re: [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0j03SLpmJhX1jBHcsrVyt+kecmfE8n8-1quCVZBN+4RvQ@mail.gmail.com>
Date:   Fri, 24 Sep 2021 18:13:30 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, Matan Ziv-Av <matan@...alib.org>,
        Mark Gross <mgross@...ux.intel.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries

On Tue, Sep 21, 2021 at 3:08 PM Rafael J. Wysocki <rafael@...nel.org> wrote:
>
> On Tue, Sep 21, 2021 at 2:52 PM Hans de Goede <hdegoede@...hat.com> wrote:
> >
> > Hi,
> >
> > On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote:
> > > BRI0A49 and BDP3336 are already on the list.
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> >
> > Thanks, patch looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> >
> > Rafael, I've picked up 1/2 since that applies to a drivers/platform/x86
> > driver. I'll leave picking this one up to you.
>
> I'll pick it up, thanks!

Applied as 5.16 material now, thanks!

> > > ---
> > >  drivers/acpi/acpi_pnp.c | 2 --
> > >  1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> > > index 8f2dc176bb41..ffdcfcd4a10d 100644
> > > --- a/drivers/acpi/acpi_pnp.c
> > > +++ b/drivers/acpi/acpi_pnp.c
> > > @@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
> > >       {"BRI0A49"},            /* Boca Complete Ofc Communicator 14.4 Data-FAX */
> > >       {"BRI1400"},            /* Boca Research 33,600 ACF Modem */
> > >       {"BRI3400"},            /* Boca 33.6 Kbps Internal FD34FSVD */
> > > -     {"BRI0A49"},            /* Boca 33.6 Kbps Internal FD34FSVD */
> > > -     {"BDP3336"},            /* Best Data Products Inc. Smart One 336F PnP Modem */
> > >       {"CPI4050"},            /* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */
> > >       {"CTL3001"},            /* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */
> > >       {"CTL3011"},            /* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */
> > >
> >