linux-kernel - Re: [PATCH stable 4.9 v2 0/4] ARM: ftrace MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YU3/1I7BfyINCb9W@sashalap>
Date:   Fri, 24 Sep 2021 12:41:56 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Alexander Sverdlin <alexander.sverdlin@...ia.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        "moderated list:ARM PORT" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH stable 4.9 v2 0/4] ARM: ftrace MODULE_PLTS warning

On Fri, Sep 24, 2021 at 09:11:18AM -0700, Florian Fainelli wrote:
>On 9/24/21 8:27 AM, Alexander Sverdlin wrote:
>> Hi Sasha,
>>
>> On 24/09/2021 13:52, Sasha Levin wrote:
>>>>> This patch series is present in v5.14 and fixes warnings seen at insmod
>>>>> with FTRACE and MODULE_PLTS enabled on ARM/Linux.
>>>>
>>>> All now queued up, thanks.
>>>
>>> Looks like 4.19 and older break the build:
>>>
>>> arch/arm/kernel/ftrace.c: In function 'ftrace_update_ftrace_func':
>>> arch/arm/kernel/ftrace.c:157:9: error: too few arguments to function 'ftrace_call_replace'
>>>   157 |   new = ftrace_call_replace(pc, (unsigned long)func);
>>>       |         ^~~~~~~~~~~~~~~~~~~
>>
>> in principle you can add ", true" as a third argument in all these ftrace_call_replace()
>> call-sites which still have two args.
>
>Sasha, what configuration failed to build? I build tested with
>mutli_v7_defconfig which does enable FTRACE by default and then ensured
>that CONFIG_ARM_MODULE_PLTS was enabled. From there I will re-submit,
>sorry about that.

allmodconfig seemed to have hit that.

-- 
Thanks,
Sasha