linux-kernel - Re: [PATCH] Staging: vt6655: Replace camel case variable name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Sep 2021 23:12:17 +0200
From:   Tommaso Merciai <tomm.merciai@...il.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Madhumitha Prabakaran <madhumithabiw@...il.com>,
        Yujia Qiao <rapiz@...mail.com>,
        Lucas Henneman <lucas.henneman@...aro.org>,
        Marcos Antonio de Jesus Filho <mdejesusfilho@...il.com>,
        Edmundo Carmona Antoranz <eantoranz@...il.com>,
        Aldas Taraškevičius <aldas60@...il.com>,
        Deepak R Varma <mh12gx2825@...il.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: vt6655: Replace camel case variable name

On Thu, Sep 23, 2021 at 09:54:12PM +0200, Fabio M. De Francesco wrote:
> On Thursday, September 23, 2021 12:07:49 AM CEST Tommaso Merciai wrote:
> > Work in progress: replace camel case variables
> > 
> > PortOffset -> port_off_set
> > 
> > Signed-off-by: Tommaso Merciai <tomm.merciai@...il.com>
> > ---
> >  drivers/staging/vt6655/baseband.c    |   6 +-
> >  drivers/staging/vt6655/card.c        |  88 ++++++++--------
> >  drivers/staging/vt6655/channel.c     |  10 +-
> >  drivers/staging/vt6655/device.h      |   2 +-
> >  drivers/staging/vt6655/device_main.c | 144 +++++++++++++--------------
> >  drivers/staging/vt6655/mac.c         |  46 ++++-----
> >  drivers/staging/vt6655/power.c       |  24 ++---
> >  drivers/staging/vt6655/rf.c          |  12 +--
> >  drivers/staging/vt6655/rxtx.c        |  12 +--
> >  9 files changed, 172 insertions(+), 172 deletions(-)
> 
> If you split "Offset" into "Off set", you convey the message that something 
> is "Off the set". Probably that's not what you want to express.
> 
> Regards,
> 
> Fabio
  
  Thanks, you're right. Resend V2.

  Tommaso
> 
>