linux-kernel - Problem with VirtIO TRIM/DISCARD?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 24 Sep 2021 14:22:17 -0700
From:   Jeppe Øland <joland@...il.com>
To:     linux-kernel@...r.kernel.org
Subject: Problem with VirtIO TRIM/DISCARD?

I'm experimenting with running VMs on a 4Kn sector array, but I'm
having some issues.
Specifically it seems VirtIO TRIM/DISCARD support may be broken for
non 512B sector sizes.

I started digging, and landed on this commit:
https://github.com/torvalds/linux/commit/af822aa68fbdf0a480a17462ed70232998127453

On line 143 the TRIM/DISCARD size is converted to a sector count - but
it's using a hardcoded sector size of 512.
Shouldn't that be using the actual block size gotten earlier?

Did that code just wipe out a ton of data following the TRIM/DISCARD area?

Regards,
-Jeppe