linux-kernel - Re: [PATCH V1 3/3] dt-bindings: tegra: clock,memory,thermal: add header Copyright

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9329dac-9eba-3657-9e51-8129d9cbbf61@nvidia.com>
Date:   Fri, 24 Sep 2021 14:43:51 -0700
From:   Bitan Biswas <bbiswas@...dia.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Rob Herring <robh+dt@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        "Jonathan Hunter" <jonathanh@...dia.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        "Ingo Molnar" <mingo@...hat.com>,
        Jassi Brar <jassisinghbrar@...il.com>,
        "Philipp Zabel" <p.zabel@...gutronix.de>
CC:     Sowjanya Komatineni <skomatineni@...dia.com>,
        Mark Brown <broonie@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>, <digetx@...il.com>,
        <mturquette@...aro.org>, <abrestic@...omium.org>
Subject: Re: [PATCH V1 3/3] dt-bindings: tegra: clock,memory,thermal: add
 header Copyright

Hi Krzysztof,

On 9/21/21 2:47 AM, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 21/09/2021 11:42, Bitan Biswas wrote:
>> Add Copyright for below Tegra dt-bindings headers:
>> 1. clock
>> 2. gpio
>> 3. mailbox
>> 4. memory
>> 5. thermal
>> 6. reset
>> 7. pinctrl
> 
> Why? Please explain.
> 
> These are trivial constants, so I doubt there is here any copyright value.
> 
You may see I was adding the missing Copyright of files created by 
Nvidia developers in past. I have not evaluated the copyright value of 
the contents added in the initial check-in. As suggested, I plan to drop 
this patch in any further revisions of patches from this list.

>>   include/dt-bindings/reset/tegra210-car.h            | 4 ++++
>>   include/dt-bindings/thermal/tegra124-soctherm.h     | 4 ++++
>>   include/dt-bindings/thermal/tegra186-bpmp-thermal.h | 4 ++++
>>   include/dt-bindings/thermal/tegra194-bpmp-thermal.h | 4 ++++
>>   22 files changed, 104 insertions(+)
>>
> 
> (...)
> 
>> diff --git a/include/dt-bindings/memory/tegra30-mc.h b/include/dt-bindings/memory/tegra30-mc.h
>> index 930f708aca17..4972cf7e3cf2 100644
>> --- a/include/dt-bindings/memory/tegra30-mc.h
>> +++ b/include/dt-bindings/memory/tegra30-mc.h
>> @@ -1,4 +1,10 @@
>>   /* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
>> + *
>> + * Author: Thierry Reding <treding@...dia.com>
>> + *
> 
> I am sorry, but that's not entirely how it works. You cannot add only
> selected (stripped) copyrights backwards. If adding, please include all
> copyright holders.
> 

I had emailed the authors(outside Nvidia) asking about additional 
Copyright to add, but did not get response from all. One author was fine 
with adding the Nvidia Copyright. I see now Copyright backwards needs us 
to follow above approach. As mentioned above in my reply to your 
comments I am planning to drop this patch if sending subsequent 
revisions in this patch list.

Thanks for the inputs.

-regards,
  Bitan