[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YU0jJxr0OJoqahHr@robh.at.kernel.org>
Date: Thu, 23 Sep 2021 20:00:23 -0500
From: Rob Herring <robh@...nel.org>
To: Zhiyong Tao <zhiyong.tao@...iatek.com>
Cc: linus.walleij@...aro.org, mark.rutland@....com,
matthias.bgg@...il.com, sean.wang@...nel.org,
srv_heupstream@...iatek.com, hui.liu@...iatek.com,
light.hsieh@...iatek.com, biao.huang@...iatek.com,
hongzhou.yang@...iatek.com, sean.wang@...iatek.com,
seiya.wang@...iatek.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v13 2/5] dt-bindings: pinctrl: mt8195: change pull
up/down description
On Wed, Sep 22, 2021 at 10:56:37AM +0800, Zhiyong Tao wrote:
> For supporting SI units in "bias-pull-down" & "bias-pull-up",
> Change pull up/down description
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@...iatek.com>
> ---
> .../bindings/pinctrl/pinctrl-mt8195.yaml | 65 ++++++++++++++++++-
> 1 file changed, 63 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> index 2f12ec59eee5..2f2afabbe4fc 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
> @@ -85,9 +85,70 @@ patternProperties:
> 2/4/6/8/10/12/14/16mA in mt8195.
> enum: [0, 1, 2, 3, 4, 5, 6, 7]
>
> - bias-pull-down: true
> + bias-pull-down:
> + description: |
> + For pull down type is normal, it don't need add RSEL & R1R0 define
> + and resistance value.
> + For pull down type is PUPD/R0/R1 type, it can add R1R0 define to
> + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" &
> + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11"
> + define in mt8195.
> + For pull down type is RSEL, it can add RSEL define & resistance value(ohm)
> + to set different resistance by identifying property "mediatek,rsel_resistance_in_si_unit".
> + It can support "MTK_PULL_SET_RSEL_000" & "MTK_PULL_SET_RSEL_001"
> + & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & "MTK_PULL_SET_RSEL_100"
> + & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & "MTK_PULL_SET_RSEL_111"
> + define in mt8195. It can also support resistance value(ohm) "75000" & "5000" in mt8195.
Please make a schema:
oneOf:
- enum: [ 0, 1, ...7 ]
- description: MT8195...
enum: [ 5000, 75000 ]
> + An example of using RSEL define:
> + pincontroller {
> + i2c0_pin {
> + pinmux = <PINMUX_GPIO8__FUNC_SDA0>;
> + bias-pull-down = <MTK_PULL_SET_RSEL_001>;
> + };
> + };
> + An example of using si unit resistance value(ohm):
> + &pio {
> + mediatek,rsel_resistance_in_si_unit;
> + }
> + pincontroller {
> + i2c0_pin {
> + pinmux = <PINMUX_GPIO8__FUNC_SDA0>;
> + bias-pull-down = <75000>;
> + };
> + };
>
> - bias-pull-up: true
> + bias-pull-up:
> + description: |
> + For pull up type is normal, it don't need add RSEL & R1R0 define
> + and resistance value.
> + For pull up type is PUPD/R0/R1 type, it can add R1R0 define to
> + set different resistance. It can support "MTK_PUPD_SET_R1R0_00" &
> + "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" & "MTK_PUPD_SET_R1R0_11"
> + define in mt8195.
> + For pull up type is RSEL, it can add RSEL define & resistance value(ohm)
> + to set different resistance by identifying property "mediatek,rsel_resistance_in_si_unit".
> + It can support "MTK_PULL_SET_RSEL_000" & "MTK_PULL_SET_RSEL_001"
> + & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011" & "MTK_PULL_SET_RSEL_100"
> + & "MTK_PULL_SET_RSEL_101" & "MTK_PULL_SET_RSEL_110" & "MTK_PULL_SET_RSEL_111"
> + define in mt8195. It can also support resistance value(ohm)
> + "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" & "75000" in mt8195.
Same here.
> + An example of using RSEL define:
> + pincontroller {
> + i2c0_pin {
> + pinmux = <PINMUX_GPIO8__FUNC_SDA0>;
> + bias-pull-up = <MTK_PULL_SET_RSEL_001>;
> + };
> + };
> + An example of using si unit resistance value(ohm):
> + &pio {
> + mediatek,rsel_resistance_in_si_unit;
> + }
> + pincontroller {
> + i2c0_pin {
> + pinmux = <PINMUX_GPIO8__FUNC_SDA0>;
> + bias-pull-up = <1000>;
> + };
> + };
>
> bias-disable: true
>
> --
> 2.25.1
>
>
Powered by blists - more mailing lists