| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Sep 2021 18:11:45 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc: Jean Delvare <jdelvare@...e.com>, Rob Herring <robh+dt@...nel.org>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: lm90: convert to dtschema
On Mon, Sep 20, 2021 at 08:19:12PM +0200, Krzysztof Kozlowski wrote:
> Convert the National LM90 hwmon sensor bindings to DT schema format.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Reviewed-by: Rob Herring <robh@...nel.org>
Applied.
Thanks,
Guenter
> ---
>
> Changes since v1:
> 1. Drop adi,adt7461 from trivial-devices.
> ---
> .../devicetree/bindings/hwmon/lm90.txt | 51 ------------
> .../bindings/hwmon/national,lm90.yaml | 79 +++++++++++++++++++
> .../devicetree/bindings/trivial-devices.yaml | 4 -
> MAINTAINERS | 2 +-
> 4 files changed, 80 insertions(+), 56 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/hwmon/lm90.txt
> create mode 100644 Documentation/devicetree/bindings/hwmon/national,lm90.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt b/Documentation/devicetree/bindings/hwmon/lm90.txt
> deleted file mode 100644
> index 398dcb965751..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/lm90.txt
> +++ /dev/null
> @@ -1,51 +0,0 @@
> -* LM90 series thermometer.
> -
> -Required node properties:
> -- compatible: manufacturer and chip name, one of
> - "adi,adm1032"
> - "adi,adt7461"
> - "adi,adt7461a"
> - "gmt,g781"
> - "national,lm90"
> - "national,lm86"
> - "national,lm89"
> - "national,lm99"
> - "dallas,max6646"
> - "dallas,max6647"
> - "dallas,max6649"
> - "dallas,max6657"
> - "dallas,max6658"
> - "dallas,max6659"
> - "dallas,max6680"
> - "dallas,max6681"
> - "dallas,max6695"
> - "dallas,max6696"
> - "onnn,nct1008"
> - "winbond,w83l771"
> - "nxp,sa56004"
> - "ti,tmp451"
> -
> -- reg: I2C bus address of the device
> -
> -- vcc-supply: vcc regulator for the supply voltage.
> -
> -Optional properties:
> -- interrupts: Contains a single interrupt specifier which describes the
> - LM90 "-ALERT" pin output.
> - See interrupt-controller/interrupts.txt for the format.
> -
> -- #thermal-sensor-cells: should be set to 1. See thermal/thermal-sensor.yaml
> - for details. See <include/dt-bindings/thermal/lm90.h> for the
> - definition of the local, remote and 2nd remote sensor index
> - constants.
> -
> -Example LM90 node:
> -
> -temp-sensor {
> - compatible = "onnn,nct1008";
> - reg = <0x4c>;
> - vcc-supply = <&palmas_ldo6_reg>;
> - interrupt-parent = <&gpio>;
> - interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
> - #thermal-sensor-cells = <1>;
> -}
> diff --git a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
> new file mode 100644
> index 000000000000..e712117da3df
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/national,lm90.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LM90 series thermometer
> +
> +maintainers:
> + - Jean Delvare <jdelvare@...e.com>
> + - Guenter Roeck <linux@...ck-us.net>
> +
> +properties:
> + compatible:
> + enum:
> + - adi,adm1032
> + - adi,adt7461
> + - adi,adt7461a
> + - dallas,max6646
> + - dallas,max6647
> + - dallas,max6649
> + - dallas,max6657
> + - dallas,max6658
> + - dallas,max6659
> + - dallas,max6680
> + - dallas,max6681
> + - dallas,max6695
> + - dallas,max6696
> + - gmt,g781
> + - national,lm86
> + - national,lm89
> + - national,lm90
> + - national,lm99
> + - nxp,sa56004
> + - onnn,nct1008
> + - ti,tmp451
> + - winbond,w83l771
> +
> +
> + interrupts:
> + items:
> + - description: |
> + Single interrupt specifier which describes the LM90 "-ALERT" pin
> + output.
> +
> + reg:
> + maxItems: 1
> +
> + "#thermal-sensor-cells":
> + const: 1
> +
> + vcc-supply:
> + description: phandle to the regulator that provides the +VCC supply
> +
> +required:
> + - compatible
> + - reg
> + - vcc-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/tegra-gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sensor@4c {
> + compatible = "onnn,nct1008";
> + reg = <0x4c>;
> + vcc-supply = <&palmas_ldo6_reg>;
> + interrupt-parent = <&gpio>;
> + interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
> + #thermal-sensor-cells = <1>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 1e4b3464d734..1eb4ce7dcdfd 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -41,10 +41,6 @@ properties:
> - adi,adp5585-02
> # Analog Devices ADP5589 Keypad Decoder and I/O Expansion
> - adi,adp5589
> - # +/-1C TDM Extended Temp Range I.C
> - - adi,adt7461
> - # +/-1C TDM Extended Temp Range I.C
> - - adt7461
> # AMS iAQ-Core VOC Sensor
> - ams,iaq-core
> # i2c serial eeprom (24cxx)
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2b990794ec35..b07679009af2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10928,7 +10928,7 @@ LM90 HARDWARE MONITOR DRIVER
> M: Jean Delvare <jdelvare@...e.com>
> L: linux-hwmon@...r.kernel.org
> S: Maintained
> -F: Documentation/devicetree/bindings/hwmon/lm90.txt
> +F: Documentation/devicetree/bindings/hwmon/national,lm90.yaml
> F: Documentation/hwmon/lm90.rst
> F: drivers/hwmon/lm90.c
> F: include/dt-bindings/thermal/lm90.h
Powered by blists - more mailing lists