linux-kernel - Re: [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210924015109.GA3029984@roeck-us.net>
Date:   Thu, 23 Sep 2021 18:51:09 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Jean Delvare <jdelvare@...e.com>, Rob Herring <robh+dt@...nel.org>,
        Jiri Kosina <trivial@...nel.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices

On Mon, Sep 20, 2021 at 08:21:09PM +0200, Krzysztof Kozlowski wrote:
> The lm70 thermometer bindings are trivial, so like many other I2C/SPI
> temperature sensors can be integrated into trivial devices bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Reviewed-by: Rob Herring <robh@...nel.org>

Applied, per Rob's comment that he prefers devices as .yaml
over .txt, and would rather have a transition from device.txt ->
trivial.yaml -> device.yaml than no transition at all.

Guenter

> ---
>  .../devicetree/bindings/hwmon/lm70.txt        | 22 -------------------
>  .../devicetree/bindings/trivial-devices.yaml  |  8 +++++++
>  2 files changed, 8 insertions(+), 22 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/lm70.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/lm70.txt b/Documentation/devicetree/bindings/hwmon/lm70.txt
> deleted file mode 100644
> index ea417a0d32af..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/lm70.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -* LM70/TMP121/LM71/LM74 thermometer.
> -
> -Required properties:
> -- compatible: one of
> -		"ti,lm70"
> -		"ti,tmp121"
> -		"ti,tmp122"
> -		"ti,lm71"
> -		"ti,lm74"
> -
> -See Documentation/devicetree/bindings/spi/spi-bus.txt for more required and
> -optional properties.
> -
> -Example:
> -
> -spi_master {
> -	temperature-sensor@0 {
> -		compatible = "ti,lm70";
> -		reg = <0>;
> -		spi-max-frequency = <1000000>;
> -	};
> -};
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 1eb4ce7dcdfd..183ee0da22c6 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -303,8 +303,13 @@ properties:
>            - ti,hdc1050
>              # Temperature and humidity sensor with i2c interface
>            - ti,hdc1080
> +            # Thermometer with SPI interface
> +          - ti,lm70
> +          - ti,lm71
>              # Temperature sensor with 2-wire interface
>            - ti,lm73
> +            # Thermometer with SPI interface
> +          - ti,lm74
>              # Temperature sensor with integrated fan control
>            - ti,lm96000
>              # I2C Touch-Screen Controller
> @@ -313,6 +318,9 @@ properties:
>            - ti,tmp102
>              # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
>            - ti,tmp103
> +            # Thermometer with SPI interface
> +          - ti,tmp121
> +          - ti,tmp122
>              # Digital Temperature Sensor
>            - ti,tmp275
>              # TI Dual channel DCAP+ multiphase controller TPS53676 with AVSBus