linux-kernel - Re: [PATCH] infiniband hfi1: fix misuse of %x in ipoib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cda0704-0e63-39b2-7874-fd679314eb2b@acm.org>
Date:   Thu, 23 Sep 2021 19:46:57 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     "Marciniszyn, Mike" <mike.marciniszyn@...nelisnetworks.com>,
        Guo Zhi <qtxuning1999@...u.edu.cn>,
        "Dalessandro, Dennis" <dennis.dalessandro@...nelisnetworks.com>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c

On 9/22/21 23:45, Leon Romanovsky wrote:
> Isn't kptr_restrict sysctl is for that?

Hi Leon,

After I sent my email I discovered the following commit: 5ead723a20e0
("lib/vsprintf: no_hash_pointers prints all addresses as unhashed"; v5.12).
I think that commit does what we need?

Thanks,

Bart.


commit 5ead723a20e0447bc7db33dc3070b420e5f80aa6
Author: Timur Tabi <timur@...nel.org>
Date:   Sun Feb 14 10:13:48 2021 -0600

     lib/vsprintf: no_hash_pointers prints all addresses as unhashed

     If the no_hash_pointers command line parameter is set, then
     printk("%p") will print pointers as unhashed, which is useful for
     debugging purposes.  This change applies to any function that uses
     vsprintf, such as print_hex_dump() and seq_buf_printf().

     A large warning message is displayed if this option is enabled.
     Unhashed pointers expose kernel addresses, which can be a security
     risk.

     Also update test_printf to skip the hashed pointer tests if the
     command-line option is set.

     Signed-off-by: Timur Tabi <timur@...nel.org>
     Acked-by: Petr Mladek <pmladek@...e.com>
     Acked-by: Randy Dunlap <rdunlap@...radead.org>
     Acked-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
     Acked-by: Vlastimil Babka <vbabka@...e.cz>
     Acked-by: Marco Elver <elver@...gle.com>
     Signed-off-by: Petr Mladek <pmladek@...e.com>
     Link: https://lore.kernel.org/r/20210214161348.369023-4-timur@kernel.org