linux-kernel - Re: [PATCH] tpm: fix potential NULL pointer access in tpm_del_char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b49f4b52-44c4-8cb8-a102-689e9f788177@gmx.de>
Date:   Fri, 24 Sep 2021 16:17:52 +0200
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     Jarkko Sakkinen <jarkko@...nel.org>, peterhuewe@....de,
        p.rosenberger@...bus.com, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] tpm: fix potential NULL pointer access in
 tpm_del_char_device()

On 24.09.21 at 15:33, Jason Gunthorpe wrote:
> On Fri, Sep 24, 2021 at 03:29:46PM +0200, Lino Sanfilippo wrote:
>
>> So this bug is triggered when the bcm2835 drivers shutdown() function is called since this
>> driver does something quite unusual: it unregisters the spi controller in its shutdown()
>> handler.
>
> This seems wrong
>
> Jason
>


Unregistering the SPI controller during shutdown is only a side-effect of calling
bcm2835_spi_remove() in the shutdown handler:

static void bcm2835_spi_shutdown(struct platform_device *pdev)
{
	int ret;

	ret = bcm2835_spi_remove(pdev);
	if (ret)
		dev_err(&pdev->dev, "failed to shutdown\n");
}


Regards,
Lino