lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <c711bbd0519dfdf3d28141cf9aa159d05f94aab7.1632565508.git.leonro@nvidia.com> Date: Sat, 25 Sep 2021 14:22:47 +0300 From: Leon Romanovsky <leon@...nel.org> To: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> Cc: Leon Romanovsky <leonro@...dia.com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Andrew Lunn <andrew@...n.ch>, Ariel Elior <aelior@...vell.com>, Bin Luo <luobin9@...wei.com>, Claudiu Manoil <claudiu.manoil@....com>, Coiby Xu <coiby.xu@...il.com>, Derek Chickles <dchickles@...vell.com>, drivers@...sando.io, Felix Manlunas <fmanlunas@...vell.com>, Florian Fainelli <f.fainelli@...il.com>, Geetha sowjanya <gakula@...vell.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, GR-everest-linux-l2@...vell.com, GR-Linux-NIC-Dev@...vell.com, hariprasad <hkelam@...vell.com>, Ido Schimmel <idosch@...dia.com>, Intel Corporation <linuxwwan@...el.com>, intel-wired-lan@...ts.osuosl.org, Ioana Ciornei <ioana.ciornei@....com>, Jerin Jacob <jerinj@...vell.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Jiri Pirko <jiri@...dia.com>, Jonathan Lemon <jonathan.lemon@...il.com>, Linu Cherian <lcherian@...vell.com>, linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org, linux-rdma@...r.kernel.org, linux-staging@...ts.linux.dev, Loic Poulain <loic.poulain@...aro.org>, Manish Chopra <manishc@...vell.com>, M Chetan Kumar <m.chetan.kumar@...el.com>, Michael Chan <michael.chan@...adcom.com>, Michael Guralnik <michaelgur@...lanox.com>, netdev@...r.kernel.org, oss-drivers@...igine.com, Richard Cochran <richardcochran@...il.com>, Saeed Mahameed <saeedm@...dia.com>, Satanand Burla <sburla@...vell.com>, Sergey Ryazanov <ryazanov.s.a@...il.com>, Shannon Nelson <snelson@...sando.io>, Simon Horman <simon.horman@...igine.com>, Subbaraya Sundeep <sbhatta@...vell.com>, Sunil Goutham <sgoutham@...vell.com>, Taras Chornyi <tchornyi@...vell.com>, Tariq Toukan <tariqt@...dia.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, UNGLinuxDriver@...rochip.com, Vadym Kochan <vkochan@...vell.com>, Vivien Didelot <vivien.didelot@...il.com>, Vladimir Oltean <vladimir.oltean@....com> Subject: [PATCH net-next v1 07/21] octeontx2: Move devlink registration to be last devlink command From: Leon Romanovsky <leonro@...dia.com> This change prevents from users to access device before devlink is fully configured. This change allows us to delete call to devlink_params_publish() and impossible check during unregister flow. Signed-off-by: Leon Romanovsky <leonro@...dia.com> --- .../ethernet/marvell/octeontx2/af/rvu_devlink.c | 10 ++-------- .../ethernet/marvell/octeontx2/nic/otx2_devlink.c | 15 +++------------ 2 files changed, 5 insertions(+), 20 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c index de9562acd04b..70bacd38a6d9 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c @@ -1510,7 +1510,6 @@ int rvu_register_dl(struct rvu *rvu) return -ENOMEM; } - devlink_register(dl); rvu_dl = devlink_priv(dl); rvu_dl->dl = dl; rvu_dl->rvu = rvu; @@ -1531,13 +1530,11 @@ int rvu_register_dl(struct rvu *rvu) goto err_dl_health; } - devlink_params_publish(dl); - + devlink_register(dl); return 0; err_dl_health: rvu_health_reporters_destroy(rvu); - devlink_unregister(dl); devlink_free(dl); return err; } @@ -1547,12 +1544,9 @@ void rvu_unregister_dl(struct rvu *rvu) struct rvu_devlink *rvu_dl = rvu->rvu_dl; struct devlink *dl = rvu_dl->dl; - if (!dl) - return; - + devlink_unregister(dl); devlink_params_unregister(dl, rvu_af_dl_params, ARRAY_SIZE(rvu_af_dl_params)); rvu_health_reporters_destroy(rvu); - devlink_unregister(dl); devlink_free(dl); } diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c index 3de18f9433ae..777a27047c8e 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c @@ -108,7 +108,6 @@ int otx2_register_dl(struct otx2_nic *pfvf) return -ENOMEM; } - devlink_register(dl); otx2_dl = devlink_priv(dl); otx2_dl->dl = dl; otx2_dl->pfvf = pfvf; @@ -122,12 +121,10 @@ int otx2_register_dl(struct otx2_nic *pfvf) goto err_dl; } - devlink_params_publish(dl); - + devlink_register(dl); return 0; err_dl: - devlink_unregister(dl); devlink_free(dl); return err; } @@ -135,16 +132,10 @@ int otx2_register_dl(struct otx2_nic *pfvf) void otx2_unregister_dl(struct otx2_nic *pfvf) { struct otx2_devlink *otx2_dl = pfvf->dl; - struct devlink *dl; - - if (!otx2_dl || !otx2_dl->dl) - return; - - dl = otx2_dl->dl; + struct devlink *dl = otx2_dl->dl; + devlink_unregister(dl); devlink_params_unregister(dl, otx2_dl_params, ARRAY_SIZE(otx2_dl_params)); - - devlink_unregister(dl); devlink_free(dl); } -- 2.31.1
Powered by blists - more mailing lists