lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <23884bb7be2cc08ae00c551a6bb7d200a75b5117.1632565508.git.leonro@nvidia.com> Date: Sat, 25 Sep 2021 14:22:46 +0300 From: Leon Romanovsky <leon@...nel.org> To: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> Cc: Leon Romanovsky <leonro@...dia.com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Andrew Lunn <andrew@...n.ch>, Ariel Elior <aelior@...vell.com>, Bin Luo <luobin9@...wei.com>, Claudiu Manoil <claudiu.manoil@....com>, Coiby Xu <coiby.xu@...il.com>, Derek Chickles <dchickles@...vell.com>, drivers@...sando.io, Felix Manlunas <fmanlunas@...vell.com>, Florian Fainelli <f.fainelli@...il.com>, Geetha sowjanya <gakula@...vell.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, GR-everest-linux-l2@...vell.com, GR-Linux-NIC-Dev@...vell.com, hariprasad <hkelam@...vell.com>, Ido Schimmel <idosch@...dia.com>, Intel Corporation <linuxwwan@...el.com>, intel-wired-lan@...ts.osuosl.org, Ioana Ciornei <ioana.ciornei@....com>, Jerin Jacob <jerinj@...vell.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Jiri Pirko <jiri@...dia.com>, Jonathan Lemon <jonathan.lemon@...il.com>, Linu Cherian <lcherian@...vell.com>, linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org, linux-rdma@...r.kernel.org, linux-staging@...ts.linux.dev, Loic Poulain <loic.poulain@...aro.org>, Manish Chopra <manishc@...vell.com>, M Chetan Kumar <m.chetan.kumar@...el.com>, Michael Chan <michael.chan@...adcom.com>, Michael Guralnik <michaelgur@...lanox.com>, netdev@...r.kernel.org, oss-drivers@...igine.com, Richard Cochran <richardcochran@...il.com>, Saeed Mahameed <saeedm@...dia.com>, Satanand Burla <sburla@...vell.com>, Sergey Ryazanov <ryazanov.s.a@...il.com>, Shannon Nelson <snelson@...sando.io>, Simon Horman <simon.horman@...igine.com>, Subbaraya Sundeep <sbhatta@...vell.com>, Sunil Goutham <sgoutham@...vell.com>, Taras Chornyi <tchornyi@...vell.com>, Tariq Toukan <tariqt@...dia.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, UNGLinuxDriver@...rochip.com, Vadym Kochan <vkochan@...vell.com>, Vivien Didelot <vivien.didelot@...il.com>, Vladimir Oltean <vladimir.oltean@....com> Subject: [PATCH net-next v1 06/21] ice: Open devlink when device is ready From: Leon Romanovsky <leonro@...dia.com> Move devlink_registration routine to be the last command, when the device is fully initialized. Signed-off-by: Leon Romanovsky <leonro@...dia.com> --- drivers/net/ethernet/intel/ice/ice_main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index aacc0b345bbe..627adf8fb89d 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -4258,8 +4258,6 @@ ice_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *ent) pf->msg_enable = netif_msg_init(debug, ICE_DFLT_NETIF_M); - ice_devlink_register(pf); - #ifndef CONFIG_DYNAMIC_DEBUG if (debug < -1) hw->debug_mask = debug; @@ -4493,6 +4491,7 @@ ice_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *ent) dev_warn(dev, "RDMA is not supported on this device\n"); } + ice_devlink_register(pf); return 0; err_init_aux_unroll: @@ -4516,7 +4515,6 @@ ice_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *ent) ice_devlink_destroy_regions(pf); ice_deinit_hw(hw); err_exit_unroll: - ice_devlink_unregister(pf); pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); return err; @@ -4593,6 +4591,7 @@ static void ice_remove(struct pci_dev *pdev) struct ice_pf *pf = pci_get_drvdata(pdev); int i; + ice_devlink_unregister(pf); for (i = 0; i < ICE_MAX_RESET_WAIT; i++) { if (!ice_is_reset_in_progress(pf->state)) break; @@ -4629,7 +4628,6 @@ static void ice_remove(struct pci_dev *pdev) ice_deinit_pf(pf); ice_devlink_destroy_regions(pf); ice_deinit_hw(&pf->hw); - ice_devlink_unregister(pf); /* Issue a PFR as part of the prescribed driver unload flow. Do not * do it via ice_schedule_reset() since there is no need to rebuild -- 2.31.1
Powered by blists - more mailing lists