lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <f8e1d59f-5473-df7c-ee23-4c0a7a4d6f11@gmail.com> Date: Sat, 25 Sep 2021 17:25:35 +0300 From: Leonard Crestez <cdleonard@...il.com> To: Jakub Kicinski <kuba@...nel.org> Cc: Dmitry Safonov <0x7f454c46@...il.com>, David Ahern <dsahern@...nel.org>, Shuah Khan <shuah@...nel.org>, Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, Herbert Xu <herbert@...dor.apana.org.au>, Kuniyuki Iwashima <kuniyu@...zon.co.jp>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Yuchung Cheng <ycheng@...gle.com>, Francesco Ruggeri <fruggeri@...sta.com>, Mat Martineau <mathew.j.martineau@...ux.intel.com>, Christoph Paasch <cpaasch@...le.com>, Ivan Delalande <colona@...sta.com>, Priyaranjan Jha <priyarjha@...gle.com>, netdev@...r.kernel.org, linux-crypto@...r.kernel.org, linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 00/19] tcp: Initial support for RFC5925 auth option On 9/23/21 4:58 PM, Jakub Kicinski wrote: > On Thu, 23 Sep 2021 10:49:53 +0300 Leonard Crestez wrote: >> Many of the patch splits were artificially created in order to ease >> review, for example "signing packets" doesn't do anything without also >> "hooking in the tcp stack". Some static functions will trigger warnings >> because they're unused until the next patch, not clear what the >> preferred solution would be here. I could remove the "static" marker >> until the next patch or reverse the order and have the initial "tcp >> integration" patches call crypto code that just returns an error and >> fills-in a signature of zeros. > > Ease of review is important, so although discouraged transient warnings > are acceptable if the code is much easier to read that way. The problem > here was that the build was also broken, but looking at it again I > think you're just missing exports, please make sure to build test with > IPV6 compiled as a module: > > ERROR: modpost: "tcp_authopt_hash" [net/ipv6/ipv6.ko] undefined! > ERROR: modpost: "__tcp_authopt_select_key" [net/ipv6/ipv6.ko] undefined! The kernel build robot sent me an email regarding IPv6=m last time, I fixed that issue but introduced another. I check for IPv6=m specifically but only did "make net/ipv4/ net/ipv6/" and missed the error. I went through the series and solved checkpatch, kernel-doc and compilation issues in a more systematic fashion, I will repost later. -- Regards, Leonard
Powered by blists - more mailing lists