linux-kernel - Re: [PATCH 1/3] usb: ehci: Fix a function name in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210925144513.GA308698@rowland.harvard.edu>
Date:   Sat, 25 Sep 2021 10:45:13 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] usb: ehci: Fix a function name in comments

On Sat, Sep 25, 2021 at 08:49:17PM +0800, Cai Huoqing wrote:
> Use dma_map_single() instead of pci_map_single(),
> because only dma_map_single() is called here.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

Acked-by: Alan Stern <stern@...land.harvard.edu>

> ---
>  drivers/usb/host/ehci-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 144080321629..3d82e0b853be 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -588,7 +588,7 @@ static int ehci_run (struct usb_hcd *hcd)
>  	 * hcc_params controls whether ehci->regs->segment must (!!!)
>  	 * be used; it constrains QH/ITD/SITD and QTD locations.
>  	 * dma_pool consistent memory always uses segment zero.
> -	 * streaming mappings for I/O buffers, like pci_map_single(),
> +	 * streaming mappings for I/O buffers, like dma_map_single(),
>  	 * can return segments above 4GB, if the device allows.
>  	 *
>  	 * NOTE:  the dma mask is visible through dev->dma_mask, so
> -- 
> 2.25.1
>