linux-kernel - Re: [PATCH] Urgent bug fix causing Apple SSDs to not work.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210925204842.GD116968@dhcp-10-100-145-180.wdc.com>
Date:   Sat, 25 Sep 2021 13:48:42 -0700
From:   Keith Busch <kbusch@...nel.org>
To:     Sagi Grimberg <sagi@...mberg.me>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Aditya Garg <gargaditya08@...e.com>,
        "axboe@...com" <axboe@...com>, "hch@....de" <hch@....de>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "james.smart@...adcom.com" <james.smart@...adcom.com>,
        "chaitanya.kulkarni@....com" <chaitanya.kulkarni@....com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "trivial@...nel.org" <trivial@...nel.org>
Subject: Re: [PATCH] Urgent bug fix causing Apple SSDs to not work.

On Sat, Sep 25, 2021 at 11:34:31PM +0300, Sagi Grimberg wrote:
> Exactly the patch that I was going to propose. The only downside
> is that we need to access the controller in the hot-path...

I initially had the same concern but noticed we already access 'ctrl' in
nvme_setup_rw() in this path, so I don't think we will be able to
measure the cost of the added check.