lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <f8e8c609-ac7f-2b6a-b8bf-57a53fadfa1d@canonical.com> Date: Sat, 25 Sep 2021 23:26:21 +0100 From: Colin Ian King <colin.king@...onical.com> To: Jiri Kosina <jikos@...nel.org>, Alexandre Torgue <alexandre.torgue@...s.st.com>, linux-input@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: NAK: [PATCH] HID: thrustmaster: Initialized pointer twi with NULL rather than 0 On 25/09/2021 23:22, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > Pointers should be initialized with NULL rather than 0. Fix this. > > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > drivers/hid/hid-thrustmaster.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c > index d44550aa8805..aa874f075bf9 100644 > --- a/drivers/hid/hid-thrustmaster.c > +++ b/drivers/hid/hid-thrustmaster.c > @@ -205,7 +205,7 @@ static void thrustmaster_model_handler(struct urb *urb) > struct tm_wheel *tm_wheel = hid_get_drvdata(hdev); > uint16_t model = 0; > int i, ret; > - const struct tm_wheel_info *twi = 0; > + const struct tm_wheel_info *twi = NULL; > > if (urb->status) { > hid_err(hdev, "URB to get model id failed with error %d\n", urb->status); > NACK, I spotted another pointer than needs the same change, will send a V2.
Powered by blists - more mailing lists