lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210925024204.GA459123@bhelgaas> Date: Fri, 24 Sep 2021 21:42:04 -0500 From: Bjorn Helgaas <helgaas@...nel.org> To: Sergio Paracuellos <sergio.paracuellos@...il.com> Cc: tsbogend@...ha.franken.de, robh@...nel.org, arnd@...db.de, catalin.marinas@....com, Liviu.Dudau@....com, bhelgaas@...gle.com, matthias.bgg@...il.com, gregkh@...uxfoundation.org, linux-mips@...r.kernel.org, linux-pci@...r.kernel.org, linux-staging@...ts.linux.dev, neil@...wn.name, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/6] PCI: allow architecture specific implementation of pci_remap_iospace() s/PCI: allow architecture specific implementation of/ PCI: Allow architecture-specific pci_remap_iospace()/ (in subject) On Fri, Sep 24, 2021 at 11:11:37PM +0200, Sergio Paracuellos wrote: > pci_remap_iospace() was originally meant as an architecture specific helper, > but it moved into generic code after all architectures had the same requirements. > MIPS has different requirements so it should not be shared. The way for doing > this will be using a macro 'pci_remap_iospace' defined for those architectures > that need a special treatement. Hence, put core api function inside preprocesor > conditional code for 'pci_remap_iospace' definition. Rewrap above to fit in 75 columns so "git log" output doesn't wrap. Add blank line between paragraphs. s/treatement/treatment/ s/api/API/ > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com> With above fixed, Acked-by: Bjorn Helgaas <bhelgaas@...gle.com> > --- > drivers/pci/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index ce2ab62b64cf..0ec57bb01a88 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -4123,6 +4123,7 @@ unsigned long __weak pci_address_to_pio(phys_addr_t address) > * architectures that have memory mapped IO functions defined (and the > * PCI_IOBASE value defined) should call this function. > */ > +#ifndef pci_remap_iospace > int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr) > { > #if defined(PCI_IOBASE) && defined(CONFIG_MMU) > @@ -4146,6 +4147,7 @@ int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr) > #endif > } > EXPORT_SYMBOL(pci_remap_iospace); > +#endif > > /** > * pci_unmap_iospace - Unmap the memory mapped I/O space > -- > 2.25.1 >
Powered by blists - more mailing lists